Skip to content

Skip password prompt - #1231

Merged
0xfornax merged 1 commit into
masterfrom
skip-password-prompt
Sep 18, 2026
Merged

0xfornax merged 1 commit into
masterfrom
skip-password-prompt

Conversation

@0xfornax

Copy link
Copy Markdown
Member

Skipping password prompt as users never need to know it.

Closes #248

@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/wallet 0.36% (-0.00%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/wallet/commands.go 0.00% (ø) 1247 0 1247
github.com/rocket-pool/smartnode/rocketpool-cli/wallet/init.go 0.00% (ø) 1636 (+56) 0 1636 (+56)
github.com/rocket-pool/smartnode/rocketpool-cli/wallet/recover.go 0.00% (ø) 3353 (+59) 0 3353 (+59)
github.com/rocket-pool/smartnode/rocketpool-cli/wallet/utils.go 0.00% (ø) 3192 (-76) 0 3192 (-76)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax
0xfornax merged commit ff77ed0 into master Sep 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing user-created wallet password on wallet init

1 participant