Skip to content

Keep the Python bindings library out of <pkg>_TARGETS #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mini-1235 wants to merge 1 commit into
base: rolling
Choose a base branch
from
+4 −2
Open

Keep the Python bindings library out of <pkg>_TARGETS #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ if(NOT TARGET Python3::Module OR NOT TARGET Python3::NumPy)
find_package(Python3 REQUIRED COMPONENTS Interpreter Development NumPy)
endif()

set(rosidl_generator_py_suffix "__rosidl_generator_py")

# Get a list of typesupport implementations from valid rmw implementations.
rosidl_generator_py_get_typesupports(_typesupport_impls)

Expand Down Expand Up @@ -168,7 +170,7 @@ add_dependencies(
target_link_libraries(
${_target_name_lib} PRIVATE
Python3::NumPy
Python3::Python
Python3::Module
)
target_include_directories(${_target_name_lib}
PRIVATE
Expand Down Expand Up @@ -262,7 +264,7 @@ if(NOT rosidl_generate_interfaces_SKIP_INSTALL)

# Export this target so downstream interface packages can depend on it
rosidl_export_typesupport_targets("${rosidl_generator_py_suffix}" "${_target_name_lib}")
ament_export_targets(export_${_target_name_lib})
ament_export_targets(export_${_target_name_lib} EXCLUDE_FROM_PACKAGE_TARGETS)
endif()

if(BUILD_TESTING AND rosidl_generate_interfaces_ADD_LINTER_TESTS)
Expand Down