Conversation
A root `rstack.config.*` without `define.test()` still becomes a bridged
Rstest project (rstack's shim returns `{}`, matching `rs test`), and its
default `include` also matches every nested native project's tests. The
same test file was published twice, VS Code merged both items into one
gutter button, and one click ran both copies: the root copy failed
(no nested plugins/aliases), the nested copy passed.
Among active projects that include a file, the one with the deepest
normalized root now owns it; equal roots keep all, explicit `projects`
aggregation still runs first. The rule is a pure function computed once
per refresh in `WorkspaceManager` and applied at publication, so an
ownership change re-publishes without re-globbing or restarting the
watcher. Non-owners keep a cheap map entry and stay live projects.
Covered by pure unit tests for the rule, two integration tests for the
late-load and config-removal transitions, and an E2E fixture that mirrors
the reported layout.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4725bd88e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Project-level Run All keeps the CLI scope: the worker runs every file its own config collects, including files another project publishes. Results for such a hidden file used to be dropped because the project holds no TestItem for it, so a failing file left the project green. The reporter now attaches a hidden file's failure to the project's own TestItem, naming the file and its errors; hidden passes stay silent.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d94254b692
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
On Windows `normalizePath` lowercases the whole path, so the relative path handed to the include/exclude matchers no longer matched a mixed-case pattern such as `Tests/**`. Containment and depth keep using the normalized paths; the glob-relative path now comes from the original casing.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12282cb1a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ation 10 Hidden non-owner failures reported on the project node now also go into the error store, so "Copy Test Item Errors" on that node finds them; the store is cleared when the project's next run starts. AGENTS.md lists test file ownership as the tenth upstream divergence so a future sync keeps it, and the gotcha keeps only the rationale.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b579ff5bc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A file this project had already resolved kept its case tree and `didResolve` after losing ownership, so the non-owner entry was a full duplicate and would never re-resolve if ownership came back. Demotion now clears the cached cases and resets the flag.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65b2f29b0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
An AST read started before a file lost ownership could finish afterwards and repopulate the hidden entry. `updateFromDisk` now resolves only after the contents are applied, and the AST resolver re-runs the non-owner demotion when the read settles, matching what the runtime path already did through `updateOrCreateFile`.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 592af0952f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…emotion `TestFile` now carries a resolve generation: every resolve start, runtime list and demotion bumps it, and an older in-flight read or listTests result is discarded when it settles after a newer one. This replaces the post-read ownership re-check and also covers the lose-then-regain case where the old predicate check let a stale read overwrite a fresh one. Demotion also clears the project's stored diagnostics for that file, so an error recorded while the project still owned the file does not linger in the Problems panel after ownership moves.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff0cd55ebf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bridged projects in one folder share the shim path used as `-c`, so `configFilePath` was not a unique diagnostics key and one project's run-start or demotion clear could wipe a sibling's diagnostics. The key is now the project's own source config URI, derived in one getter.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0970fcdda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ear hidden failures on recovery
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fb323b4b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 805db0a366
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5c62e5aa6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // only update test file result when explicit run itself or parent | ||
| if (this.path.length) return; | ||
|
|
||
| if (this.isHiddenFile(test.testPath)) { |
There was a problem hiding this comment.
When a shallow project has a visible TestFolder spanning a directory that also contains a deeper project's hidden file, index.ts:463-467 passes the directory as fileFilter, so the shallow CLI run can still execute that hidden file. This branch stores a failure on the project item, but rerunning the same folder after the file passes returns without clearing the stored error or marking the project passed because recovery is gated on projectWide; the project remains red and “Copy Test Errors” stays stale until a full-project run. Fresh evidence beyond the earlier projectWide-gating thread is that the partial folder run can itself create the hidden failure, so that same scope must be able to recover its result.
AGENTS.md reference: packages/vscode/AGENTS.md:L26-L26
Useful? React with 👍 / 👎.
1 participant
Summary
A root
rstack.config.*withoutdefine.test()still becomes a bridged Rstest project (rstack's shim returns{}, which matches whatrs testdoes), and its defaultincludealso matches every nested native project's tests. The same test file was published under both projects, VS Code merged the two items into one gutter button, and one click ran both copies: the root copy failed (no nested plugins or aliases) and the nested copy passed.This PR makes the project with the deepest normalized root own an overlapping test file:
projectsaggregation (projectCoverage) still runs first.computeFileOwnershipinprojectCoverage.ts, computed once per refresh inWorkspaceManager, and applied at publication (buildTree) plus the per-file resolve gate inupdateOrCreateFile. An ownership change re-publishes without re-globbing or restarting the watcher.Behavior that does not change:
rs test/ CLI semantics, project-level Run All (still uses each project's own config), the lint and fmt stacks.Related Links
rs testshould run at all withoutdefine.test()) is tracked separately in rs test / rs lint run with an empty config when define.test() / define.lint() is missing: intended or an oversight? rstack-cli#490; maintainers confirmed the current CLI behavior is intended, so the editor follows it and only arbitrates the overlap.Checklist