Repository navigation
Update shell-quote, source-map-js and form-data for security fixes - #332
Merged
Merged
Conversation
fx-runner pins shell-quote to 1.10.0 and request pins form-data to ~2.3.2, so both need overrides to get the fixed versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the critical and high npm Dependabot alerts that have a fix. All are dev dependencies.
overridesentry for fx-runner. This is why the Dependabot update for shell-quote failed.form-data@~2.3.2and won't get another release, so this adds a scoped override for request. 2.5 is the same major version.Still open:
scripts/generate-icons.jswith something like sharp or resvg. That would clear all of these and the form-data override.docs/Gemfile.lock(chore(deps): update dependency y18n to 4.0.1 [security] - autoclosed #169): not updated here. That needsbundle update rubyzip --conservativewith Ruby, which I'll do separately.Checked locally:
npm test(lint, unit tests, Chrome/Edge/Firefox builds, manifest smoke test, zips, web-ext lint). I didn't runbuild:icons, since phantomjs's install script doesn't run under the current npm defaults.