Repository navigation
Generate icons with resvg instead of svg2png - #333
Merged
Merged
Conversation
svg2png depends on the unmaintained phantomjs-prebuilt, which pulls in several packages with security alerts. resvg renders the same icons without a headless browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`scripts/generate-icons.js` now renders the icons with `@resvg/resvg-js` instead of `svg2png`. svg2png depends on the unmaintained `phantomjs-prebuilt`, which brought in about 8 of the open Dependabot alerts. Removing it drops about 1,800 lines from the lockfile.
The logo is wider than it is tall. svg2png centered it in a square canvas, so the script now centers it in a square viewBox to produce the same square icons. I regenerated every icon size with `npm run build:icons`, and the new icons match the old ones at 16px and 128px.