Repository navigation
Conversation
react-router-dom 7 needs React 18 or later, so both move together. The entry points switch from ReactDOM.render to createRoot.
7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the open react-router Dependabot alerts (#134, #136), which are fixed in react-router 7.18.0. react-router-dom 7 requires React 18 or later, so this also moves React and react-dom from 17 to 18. That's why this can't be a router-only change.
Changes:
manage.jsxandcreate-filters.jsxusecreateRootfromreact-dom/clientinstead ofReactDOM.render, which React 18 deprecates.The router code didn't need changes. The app only uses
HashRouter,Routes,Route,NavLink, anduseLocation, and those work the same in v7. It still imports fromreact-router-dom, which v7 keeps as a re-export ofreact-router.The rest of the UI stack (MUI 5, @material-table/core 6.2, notistack 2, material-ui-confirm 3, react-dropzone 14) already supports React 18, so it stays as is. The uuid alert (#121) needs @material-table/core 8 and React 19. That's in the stacked follow-up, #335.
Checks
npm testpasses: lint (same 2 existing unused-directive warnings inmenus.js), unit tests (2/2), Chrome/Edge/Firefox builds, manifest smoke test, zips, and web-ext lint (0 errors).npm lsreports no invalid or missing peer dependencies..output/chrome-mv3loaded as an unpacked extension in Playwright Chromium. 14/14 checks passed:#/users,#/keywords, and back to#/, and a deep link to#/keywordsrenders.smoke-test-usershows the row, updates the count, and writes tostorage.local. An invalid name (bad name!) shows the pattern hint and isn't stored. Deleting the row removes it from storage.create-filters.htmlrenders its dialog.defaultPropsdeprecation warnings from @material-table/core 6 under React 18.3, and an MUIanchorElwarning. Both go away in Upgrade to React 19, MUI 9, and @material-table/core 8 #335.Manual test list