Skip to content

Make string_value raise what StringValue raises #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youdie006 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

Make string_value raise what StringValue raises #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cgi/escape.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,6 @@ def unescapeElement(string, *elements)

# Like StringValue in C
def string_value(input) # :nodoc:
String.try_convert(input) || raise(TypeError, "no implicit conversion of #{input.class} into String")
String === input ? input : "" + input
end
end
8 changes: 8 additions & 0 deletions test/cgi/test_cgi_escape.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,14 @@ def teardown
end if defined?(CGI::EscapeExt) and CGI::EscapeExt.method_defined?(:_escapeHTML)
end

def test_escapeHTML_type_error_matches_c_extension
assert_raise_with_message(TypeError, "no implicit conversion of nil into String") { CGI.escapeHTML(nil) }
assert_raise_with_message(TypeError, "no implicit conversion of true into String") { CGI.escapeHTML(true) }
assert_raise_with_message(TypeError, "no implicit conversion of false into String") { CGI.escapeHTML(false) }
assert_raise_with_message(TypeError, "no implicit conversion of nil into String") { CGI.unescapeHTML(nil) }
assert_raise(TypeError) { CGI.escapeHTML(BasicObject.new) }
end

include CGIEscapeTest::UnescapeHTMLTests

def test_cgi_escapeHTML_with_invalid_byte_sequence
Expand Down