Skip to content

Make ossl_sslctx_type RUBY_TYPED_THREAD_SAFE_FREE - #1112

Merged
rhenium merged 1 commit into
ruby:masterfrom
luke-gruber:ssl_context_thread_safe_free
Sep 21, 2026
Merged

rhenium merged 1 commit into
ruby:masterfrom
luke-gruber:ssl_context_thread_safe_free

Conversation

@luke-gruber

Copy link
Copy Markdown
Contributor

It's safe to free these types during Ractor-local GC in Ruby 4.1. We've seen the freeing of this type show up in profiles before.

@rhenium

rhenium commented Sep 21, 2026

Copy link
Copy Markdown
Member

This looks good to me because all *_free() functions in OpenSSL should be thread safe.

We should do the same to all classes.

@rhenium
rhenium force-pushed the ssl_context_thread_safe_free branch from 2377ed7 to ce46092 Compare September 21, 2026 13:36
It's safe to free these types during Ractor-local GC in Ruby 4.1. We've
seen the freeing of this type show up in profiles before.

Co-authored-by: Kazuki Yamaguchi <k@rhe.jp>
@rhenium
rhenium force-pushed the ssl_context_thread_safe_free branch from ce46092 to e481c64 Compare September 21, 2026 13:38
@rhenium
rhenium merged commit cfa7645 into ruby:master Sep 21, 2026
48 checks passed
@rhenium

rhenium commented Sep 21, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants