ssl: clear error queue before raising SystemCallError - #1115
Merged
rhenium merged 1 commit intoSep 24, 2026
Merged
Conversation
Clear the OpenSSL error queue when an OpenSSL function fails with SSL_ERROR_SYSCALL. ruby/openssl methods are expected not to leave stale entries in the error queue. While this no longer appears to happen with OpenSSL >= 3.0, LibreSSL and older versions of OpenSSL may generate an ERR_LIB_SYS entry in the error queue when the underlying socket fails with an errno. This entry must be cleared before another OpenSSL function is called, otherwise SSL_get_error() for that call may return an incorrect result. Fixes ruby#1114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the OpenSSL error queue when an OpenSSL function fails with
SSL_ERROR_SYSCALL. ruby/openssl methods are expected not to leave stale entries in the error queue.While this no longer appears to happen with OpenSSL >= 3.0, LibreSSL and older versions of OpenSSL may generate an
ERR_LIB_SYSentry in the error queue when the underlying socket fails with anerrno. This entry must be cleared before another OpenSSL function is called, otherwiseSSL_get_error()for that call may return an incorrect result.Fixes #1114