Add set_interrupt_model_used method for calling \_PIC - #357
Conversation
Tested on QEMU q35 and Lenovo Ideapad Z560.
|
Looks pretty reasonable from a first look. A couple of minor points, and one other thought:
What do you think? |
|
My only concern with naming it |
| #[derive(Debug, Clone, Copy)] | ||
| pub enum InterruptModelUsed { | ||
| /// 0 - PIC mode | ||
| PicMode, |
There was a problem hiding this comment.
Any reason not to either add the values to the first three, or remove from the last three?
There was a problem hiding this comment.
I left the first 3 to 0,1,2 implicitly, there's no reason not to add the values to them, I just felt lazy ig. The important thing is that 3 is left as Reserved.
Ah that does make sense! 😆 Thanks for the tweaks. In principle I'm happy, but I want to think a little more about the interrupt model types and names. (Although I'm aware that we need to do a semver version bump in the future anyway, so we could adjust this later. I won't leave this hanging PR too long.) |
|
I guess |
Closes #356
Tested on QEMU q35 and Lenovo Ideapad Z560.