You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using salt-ssh 3001.1 installed in a virtualenv. Minion is Debian Buster, no master.
Pillar / config used
top.sls contains
base:
'*':
- php
No pillar.
Bug details
Describe the bug
This does not work out of the box
----------
ID: php_install_php
Function: pkg.installed
Name: php
Result: False
Comment: The following packages failed to install/update: php7.0
Started: 13:21:35.587509
Duration: 578.336 ms
Changes:
Steps to reproduce the bug
Expected behaviour
I expect the formula to work out of the box, with sane defaults so I can use it to simply install available PHP packages on Debian distribution.
Attempts to fix the bug
I still have not looked at how the formula exactly works, but it looks like without external repository I can't use it to use PHP packages from vanilla Debian repositories.
which lets the formula find all php-* packages available on Debian. Those names are always available and pull available versions (7.1 for oldstable, 7.3 for stable, 7.4 for actual testing)
I think we should make it default to just php, which is Debian's meta-package to latest version available for the distro, right?
Though I checked the map.jinja and php.installed.jinja, and the value for php_version is hardcoded in both.
I think this formula needs some major refactoring roll_eyes
Could work for simple setup (like stated in the description) but once you want php.fpm you need to have the correct version number because the service is named php<version>-fpm.
Activity
daks commentedon Oct 30, 2020
Solved using following pillar
which lets the formula find all
php-*packages available on Debian. Those names are always available and pull available versions (7.1 for oldstable, 7.3 for stable, 7.4 for actual testing)javierbertoli commentedon Oct 30, 2020
I think we should make it default to just
php, which is Debian's meta-package to latest version available for the distro, right?Though I checked the
map.jinjaandphp.installed.jinja, and the value forphp_versionis hardcoded in both.I think this formula needs some major refactoring 🙄
myii commentedon Oct 30, 2020
This shares a common thread with #214, #215 and #216, in that this formula needs to go through the following steps:
map.jinjaverifier (after finalising the PR in theopenvpn-formula).map.jinjaand YAML files (even if v3 rather than v4 -- although I'd prefer the latter).daks commentedon Nov 7, 2020
Could work for simple setup (like stated in the description) but once you want
php.fpmyou need to have the correct version number because the service is namedphp<version>-fpm.Not easy to solve...
feat(php): manage `map.jinja` verification