Skip to content

Fix stale remote server picker responses overwriting newer ones #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderandhiker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix stale remote server picker responses overwriting newer ones #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion frontend/src/lib/components/RemoteServerPicker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,24 @@
const restartPicker = _.debounce(async () => {
await stopPicker();
if (!disabled) {
const forBasePath = basePath;
try {
pickerId = await StartPicker(basePath);
const newPickerId = await StartPicker(forBasePath);
// If the base path has changed since the request was made,
// or the picker has been disabled, ignore the response and release the picker
if (basePath !== forBasePath || disabled) {
await StopPicker(newPickerId);
return;
}
pickerId = newPickerId;
currentBasePath = basePath;
setupError = null;
} catch (e) {
// If the base path has changed since the request was made,
// or the picker has been disabled, ignore the response
if (basePath !== forBasePath || disabled) {
return;
}
setupError = e as string;
pendingValidCheck = false;
}
Expand Down