feat: authenticate sftp installations with ssh keys - #86
Open
coderandhiker wants to merge 1 commit into
Open
coderandhiker wants to merge 1 commit into
coderandhiker wants to merge 1 commit into
Conversation
sftp installations could only authenticate with a password in the url, so servers that disable password authentication could not be managed. sftp now also offers public keys from a running ssh agent (SSH_AUTH_SOCK, or the OpenSSH agent's named pipe on windows) and from the unencrypted default key files in ~/.ssh. Passphrase-protected key files are skipped with a hint to add them to the agent. A password in the url is still tried first, so existing installations behave as before. The test serves sftp in-process with the ssh and sftp packages already in use, so it runs without the docker sftp container. Refs satisfactorymodding/SatisfactoryModManager#304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sftp installations could only authenticate with a password in the url, so servers that disable password authentication could not be managed.
sftp now also offers public keys from a running ssh agent (SSH_AUTH_SOCK, or the OpenSSH agent's named pipe on windows) and from the unencrypted default key files in ~/.ssh. Passphrase-protected key files are skipped with a hint to add them to the agent. A password in the url is still tried first, so existing installations behave as before.
The test serves sftp in-process with the ssh and sftp packages already in use, so it runs without the docker sftp container.
Refs satisfactorymodding/SatisfactoryModManager#304 but the fix looks to be here. I filed a bug fix related PR for the SMM desktop app: satisfactorymodding/SatisfactoryModManager#367.