Skip to content

[PLA4-44978] Remove Celery autoscaler timing logs #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelshih wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −8
Open

[PLA4-44978] Remove Celery autoscaler timing logs #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions model-engine/model_engine_server/core/celery/celery_autoscaler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,13 @@ async def list_deployments(apps_api) -> Dict[Tuple[str, str], CeleryAutoscalerPa
namespaces_to_scan = list(dict.fromkeys([endpoint_namespace, "default"]))
celery_deployments_params = {}
for namespace_name in namespaces_to_scan:
namespace_start_time = time.time()
try:
deployments = await apps_api.list_namespaced_deployment(namespace=namespace_name)
except ApiException as exc:
# Don't let a failure in one namespace (e.g. missing RBAC) wipe out scaling for the
# other. Log and move on; the next iteration of the outer loop will retry.
logger.error(f"Failed to list deployments in namespace {namespace_name}: {exc}")
continue
logger.info(
f"list_namespaced_deployment in {namespace_name} took {time.time() - namespace_start_time} seconds"
)
for deployment in deployments.items:
deployment_name = deployment.metadata.name
annotations = deployment.metadata.annotations
Expand Down Expand Up @@ -647,7 +643,6 @@ async def main():
try:
loop_start = time.time()
deployments = await list_deployments(apps_api=apps_api)
logger.info(f"list_deployments took {time.time() - loop_start} seconds")
celery_queues = set()
celery_queues_params = []
for deployment_and_namespace, params in sorted(
Expand Down Expand Up @@ -677,9 +672,7 @@ async def main():

# Get queue sizes
# (queue_name, db_index) -> QueueSizes
start_get_metrics = time.time()
metrics = await get_metrics(broker, inspect=inspect, queues=celery_queues)
logger.info(f"get_metrics took {time.time() - start_get_metrics} seconds")

queue_sizes = metrics.broker_metrics.queue_sizes
for k, v in sorted(queue_sizes.items()):
Expand All @@ -700,7 +693,6 @@ async def main():

# Wait before next iteration
iteration_len = time.time() - loop_start
logger.info(f"Iteration length: {iteration_len} seconds.")
if iteration_len < 3:
await aio.sleep(3 - iteration_len)

Expand Down