Conversation
Use fixed messages and metadata for request, HTTP, ACP, and Redis logs. Keep request handling and streaming behavior unchanged. This cleanup follows the optional observability adapter.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Replace selected API, HTTP client, ACP, and Redis log calls with fixed templates and safe metadata instead of bodies, URLs, or exception values.
This PR follows #434. Its base is that PR's branch; merge #434 first, then retarget this PR to
main. It includes the adapter foundation, predicate rename, and native-handler fix; application log-call cleanup stays in this follow-up.Changes
Test Plan
This covers selected log calls, not a repository-wide payload audit. No logging-lint tooling or CI baseline is included.
The PR appears safe to merge. No new blocking issue was found.
What we checked:
Summary
Selected logs now omit request, stream, and exception contents while keeping safe metadata for tracing and operations.
Diagram
sequenceDiagram participant Client participant Route as LoggedAPIRoute participant Handler participant Downstream as ACP/HTTP/Redis Client->>Route: Request with headers, query, and body Route->>Route: Log method, route template, size, request ID Route->>Handler: Forward full request Handler->>Downstream: Send required payload Downstream->>Downstream: Log safe metadata only Downstream-->>Handler: Result or stream chunks Handler-->>Route: Response Route->>Route: Log status, method, route template, request ID Route-->>Client: Full responseReviews (5) · Last reviewed commit: "Merge branch 'harvhan/runtime-observabil..."