Skip to content

CLDSRV-909: Reject CopyObject when source exceeds 5 GiB (backport) - #6233

Merged
bert-e merged 5 commits into
development/9.3from
bugfix/CLDSRV-909-enforce-copyobject-source-size-limit
Sep 29, 2026
Merged

bert-e merged 5 commits into
development/9.3from
bugfix/CLDSRV-909-enforce-copyobject-source-size-limit

Conversation

@tcarmet

@tcarmet tcarmet commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Backport of #6177 to development/9.3.

Align cloudserver's CopyObject with the AWS S3 contract by rejecting requests whose source object exceeds 5 GiB. AWS S3 returns HTTP 400 InvalidRequest ("The specified copy source is larger than the maximum allowable size for a copy source: 5368709120") and expects clients to use the multipart copy flow instead; cloudserver previously accepted these requests. The bypassMaxPutObjectSize flag still overrides the limit, matching the PutObject behavior.

The first commit is a prettier-only reformat of the two touched files and can be skipped during review; the actual change lives in the three cherry-picked commits.

@bert-e

bert-e commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-909 contains:

  • 9.4.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.14

  • 9.4.0

Please check the Fix Version/s of CLDSRV-909, or the target
branch of this pull request.

@codecov

codecov Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.71429% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.33%. Comparing base (03ccd96) to head (654b065).
⚠️ Report is 5 commits behind head on development/9.3.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/objectCopy.js 89.71% 18 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/objectCopy.js 91.33% <89.71%> (-0.16%) ⬇️

... and 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6233      +/-   ##
===================================================
+ Coverage            85.28%   85.33%   +0.05%     
===================================================
  Files                  206      206              
  Lines                13435    13442       +7     
===================================================
+ Hits                 11458    11471      +13     
+ Misses                1977     1971       -6     
Flag Coverage Δ
file-ft-tests 68.34% <84.00%> (-0.06%) ⬇️
file-ft-tests-null-compat 68.84% <84.00%> (-0.03%) ⬇️
kmip-ft-tests 28.35% <57.14%> (+<0.01%) ⬆️
mongo-v0-ft-tests 69.60% <84.00%> (+0.05%) ⬆️
mongo-v1-ft-tests 69.62% <84.00%> (+0.07%) ⬆️
multiple-backend 36.80% <2.28%> (-0.02%) ⬇️
s3c-ft-tests-v0 63.98% <84.00%> (-0.02%) ⬇️
s3c-ft-tests-v0-null-compat 64.04% <84.00%> (-0.02%) ⬇️
s3c-ft-tests-v1 63.96% <84.00%> (-0.04%) ⬇️
sur-tests 35.97% <15.42%> (-0.02%) ⬇️
sur-tests-inflights 37.79% <15.42%> (-0.02%) ⬇️
unit 71.28% <72.00%> (+<0.01%) ⬆️
utapi-v2-tests 34.63% <56.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tcarmet
tcarmet requested a review from a team July 21, 2026 21:20
@tcarmet
tcarmet marked this pull request as ready for review July 21, 2026 21:20
@tcarmet
tcarmet requested a review from a team July 21, 2026 21:44
@tcarmet

tcarmet commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/9.4/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit with contents from bugfix/CLDSRV-909-enforce-copyobject-source-size-limit
and development/9.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.4/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit origin/development/9.4
 git merge origin/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.4/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit

The following options are set: create_integration_branches

@tcarmet
tcarmet force-pushed the bugfix/CLDSRV-909-enforce-copyobject-source-size-limit branch from 6ef6cf5 to 654b065 Compare September 29, 2026 18:51
@bert-e

bert-e commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-909 contains:

  • 9.3.14

  • 9.4.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.22

  • 9.4.5

  • 9.5.0

Please check the Fix Version/s of CLDSRV-909, or the target
branch of this pull request.

The following options are set: create_integration_branches

@bert-e

bert-e commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/9.5/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit with contents from w/9.4/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit
and development/9.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.5/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit origin/development/9.5
 git merge origin/w/9.4/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.5/bugfix/CLDSRV-909-enforce-copyobject-source-size-limit

The following options are set: create_integration_branches

@bert-e

bert-e commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@tcarmet

tcarmet commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.3

  • ✔️ development/9.4

  • ✔️ development/9.5

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/7.10.15
  • hotfix/7.4.2
  • hotfix/7.70.51
  • hotfix/6.4.7
  • hotfix/7.10.30
  • hotfix/7.10.4
  • hotfix/7.70.45
  • hotfix/7.70.73
  • hotfix/9.2.36
  • hotfix/9.3.13
  • hotfix/7.10.28
  • hotfix/7.70.11
  • hotfix/9.2.24
  • hotfix/7.4.1
  • hotfix/7.2.0
  • hotfix/7.4.7
  • hotfix/7.10.8
  • hotfix/7.4.5
  • hotfix/7.4.6
  • hotfix/7.70.21
  • hotfix/7.10.3
  • hotfix/7.10.1
  • hotfix/7.7.0
  • hotfix/7.9.0
  • hotfix/7.8.0
  • hotfix/7.10.27
  • hotfix/7.4.9
  • hotfix/7.4.10
  • hotfix/7.10.49
  • hotfix/7.4.8
  • hotfix/7.10.2
  • hotfix/9.0.32
  • hotfix/7.6.0
  • hotfix/9.0.7
  • hotfix/8.8.45
  • hotfix/7.10.0
  • hotfix/7.4.4
  • hotfix/7.4.3
  • hotfix/7.4.0

Please check the status of the associated issue CLDSRV-909.

Goodbye tcarmet.

The following options are set: approve, create_integration_branches

@bert-e
bert-e merged commit 654b065 into development/9.3 Sep 29, 2026
37 checks passed
@bert-e
bert-e deleted the bugfix/CLDSRV-909-enforce-copyobject-source-size-limit branch September 29, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants