Report scal-replica for replicas without the isReplica flag

[maeldonn]

The isReplica field was introduced in 9.4 with no metadata migration, so objects replicated before the upgrade only carry the legacy encoding status === 'REPLICA' and never got the x-amz-meta-scal-replica header. Accept both encodings, same semantics as arsenal ObjectMD.getReplicationIsReplica().

Issue: CLDSRV-994

[bert-e]

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/bypass_source_branch_lineage	Bypass the cross-branch contamination check	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request.
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-994 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.4.4

• 9.5.0

Please check the Fix Version/s of CLDSRV-994, or the target
branch of this pull request.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (691163d) to head (c39c002).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/utilities/collectResponseHeaders.js	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.4    #6290      +/-   ##
===================================================
- Coverage            86.50%   86.46%   -0.05%     
===================================================
  Files                  212      212              
  Lines                14581    14581              
===================================================
- Hits                 12614    12607       -7     
- Misses                1967     1974       +7     

Flag	Coverage Δ
checksums-disabled-tests	35.31% <100.00%> (ø)
file-ft-tests	70.00% <100.00%> (ø)
file-ft-tests-null-compat	70.48% <100.00%> (ø)
kmip-ft-tests	28.27% <0.00%> (+0.17%)	⬆️
mongo-v0-ft-tests	71.10% <100.00%> (-0.03%)	⬇️
mongo-v1-ft-tests	71.11% <100.00%> (-0.04%)	⬇️
multiple-backend	36.08% <100.00%> (ø)
s3c-ft-tests-v0	65.02% <100.00%> (-0.02%)	⬇️
s3c-ft-tests-v0-null-compat	65.07% <100.00%> (ø)
s3c-ft-tests-v1	65.00% <100.00%> (ø)
sur-tests	36.59% <0.00%> (ø)
sur-tests-inflights	39.44% <0.00%> (ø)
unit	74.21% <100.00%> (ø)
utapi-v2-tests	35.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[maeldonn]

/approve

[bert-e]

Conflict

A conflict has been raised during the creation of
integration branch w/9.5/bugfix/CLDSRV-994/replica with contents from bugfix/CLDSRV-994/replica
and development/9.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.5/bugfix/CLDSRV-994/replica origin/development/9.5
 git merge origin/bugfix/CLDSRV-994/replica
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.5/bugfix/CLDSRV-994/replica

The following options are set: approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/9.4

• ✔️ development/9.5

The following branches will NOT be impacted:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2
• development/9.3

This pull request does not target the following hotfix branch(es) so they
will be left untouched:

• hotfix/7.10.15
• hotfix/7.4.2
• hotfix/7.70.51
• hotfix/6.4.7
• hotfix/7.10.30
• hotfix/7.10.4
• hotfix/7.70.45
• hotfix/7.70.73
• hotfix/9.2.36
• hotfix/9.3.13
• hotfix/7.10.28
• hotfix/7.70.11
• hotfix/9.2.24
• hotfix/7.4.1
• hotfix/7.2.0
• hotfix/7.4.7
• hotfix/7.10.8
• hotfix/7.4.5
• hotfix/7.4.6
• hotfix/7.70.21
• hotfix/7.10.3
• hotfix/7.10.1
• hotfix/7.7.0
• hotfix/7.9.0
• hotfix/7.8.0
• hotfix/7.10.27
• hotfix/7.4.9
• hotfix/7.4.10
• hotfix/7.10.49
• hotfix/7.4.8
• hotfix/7.10.2
• hotfix/9.0.32
• hotfix/7.6.0
• hotfix/9.0.7
• hotfix/8.8.45
• hotfix/7.10.0
• hotfix/7.4.4
• hotfix/7.4.3
• hotfix/7.4.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.4

• ✔️ development/9.5

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2
• development/9.3

Please check the status of the associated issue CLDSRV-994.

Goodbye maeldonn.