Repository navigation
fix gaps in parsed target priority lists - #7904
Open
Goober5000 wants to merge 1 commit into
Open
Goober5000 wants to merge 1 commit into
Goober5000 wants to merge 1 commit into
Conversation
Both the subsystem $Target Priority: parser and the weapon +Target Priority: parser stored each recognized group at the index of its position in the table list, while the count only incremented on matches. An unrecognized name therefore left a -1 hole inside the counted range (and pushed later valid entries outside it), which the turret targeting code then used as an index into Ai_tp_list. Consolidate the two loops into parse_target_priority_list(), which packs the recognized entries at the front of the array. Unrecognized names are now reported via error_display in both cases, with context naming the subsystem or weapon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the subsystem $Target Priority: parser and the weapon +Target Priority: parser stored each recognized group at the index of its position in the table list, while the count only incremented on matches. An unrecognized name therefore left a -1 hole inside the counted range (and pushed later valid entries outside it), which the turret targeting code then used as an index into Ai_tp_list.
Consolidate the two loops into parse_target_priority_list(), which packs the recognized entries at the front of the array. Unrecognized names are now reported via error_display in both cases, with context naming the subsystem or weapon.
NOTE: CI checks will fail until #7903 is merged and this branch is rebased.