Skip to content

Non-null assertion cleanup PART 1 - #706

Open
growabeard wants to merge 8 commits into
scribe-org:mainfrom
growabeard:non-null-assertion-cleanup
Open

growabeard wants to merge 8 commits into
scribe-org:mainfrom
growabeard:non-null-assertion-cleanup

Conversation

@growabeard

@growabeard growabeard commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

This PR is fixing non-null assertions in a few classes, with tests accompanying the changes.

This is only the first PR in a series of work.

Related issue

@andrewtavis andrewtavis added the no-changelog No changelog entry is needed for this pull request label Sep 25, 2026
@andrewtavis

Copy link
Copy Markdown
Member

Thanks for the PR, @growabeard! Would you be able to fix the Ktlint issues?

@growabeard

growabeard commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator Author

Egg on my face. I ran lintKotlin but ignored the output.. 👻

@andrewtavis

Copy link
Copy Markdown
Member

No stress, @growabeard! @prince-0408 and/or @Roniscend: Would either of you be able to do an initial review?

How many parts do you think you'll do for the PRs, @growabeard? Just wondering if you have an impression :)

@growabeard

growabeard commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

@andrewtavis

How many parts do you think you'll do for the PRs, @growabeard? Just wondering if you have an impression :)

I think just one more actually. I should have the second one ready this week.

@andrewtavis

Copy link
Copy Markdown
Member

Sounds great, @growabeard!

Comment thread app/src/keyboards/java/be/scri/helpers/RecentEmojiHelper.kt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No changelog entry is needed for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants