fix(deps): resolve tmp to 0.2.7 to clear path traversal advisory - #1335
Open
sunitaprajapati89 wants to merge 1 commit into
Open
sunitaprajapati89 wants to merge 1 commit into
sunitaprajapati89 wants to merge 1 commit into
Conversation
GHSA-ph9p-34f9-6g65: tmp < 0.2.6 allows path traversal via unsanitized prefix/postfix. Dev/CI tooling only (detox, changesets) — not shipped. Adds two descriptor-scoped resolutions. detox's ^0.2.1 range already admits 0.2.7, but pinning it stops a future `yarn up` sliding back. external-editor's ^0.0.33 needs the override outright: caret on a 0.0.x version pins the patch, so it can never reach the 0.2.x line that carries the fix. Both consumers verified against 0.2.7: - external-editor calls only tmpNameSync(fileOptions), and @changesets/cli constructs ExternalEditor with no arguments, so fileOptions is {} and nothing reaches the new prefix/postfix checks. - detox passes template 'detox-<pid>-XXXXXX<ext>' and setGracefulCleanup(); both still exported, and the template check only requires XXXXXX to appear somewhere in the string. Lockfile collapses to a single tmp@0.2.7 and drops os-tmpdir. Confirmed with yarn why tmp, yarn npm audit (advisory gone), yarn install --immutable, and a require-and-allocate smoke test of each consumer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHSA-ph9p-34f9-6g65: tmp < 0.2.6 allows path traversal via unsanitized prefix/postfix. Dev/CI tooling only (detox, changesets) — not shipped.
Adds two descriptor-scoped resolutions. detox's ^0.2.1 range already admits 0.2.7, but pinning it stops a future
yarn upsliding back. external-editor's ^0.0.33 needs the override outright: caret on a 0.0.x version pins the patch, so it can never reach the 0.2.x line that carries the fix.Both consumers verified against 0.2.7:
Lockfile collapses to a single tmp@0.2.7 and drops os-tmpdir. Confirmed with yarn why tmp, yarn npm audit (advisory gone), yarn install --immutable, and a require-and-allocate smoke test of each consumer.