Repository navigation
Conversation
A pull request that changes only files under docs/, or .md and .rst files, now skips the build, test, lint and sanitizer jobs in CI and Quality. scripts/ci_code_changed.sh decides from the merge commit diff. Renames count on both sides, so moving a source file under docs/ still runs everything. Pushes to main always run everything. ci-ok and quality-ok always run. They fail when a job they depend on failed or was cancelled, and on a code change also when one was skipped. They are the checks branch rules should require. A matrix job skipped by its `if` reports one check with the matrix expression unexpanded, so a required check named after a matrix job would never report. postgres and clang-tidy stay outside the gates, as they are not required today. Also pass the clang-tidy file list through an array and split the TSAN_OPTIONS exports from their assignment, which actionlint flagged.
gateway_error_codes_documented reads docs/api/rest.rst and gateway_doc_test_citations reads docs/api and the gateway design docs. Both are linter tests, and only format-lint runs those, so it now runs on every pull request. A docs-only pull request still skips the build, test, clang-tidy and sanitizer jobs. The classifier now reads paths with core.quotePath=false. A non-ASCII name under docs/ was quoted and counted as code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary draft. It runs the docs-only path from branch ci/skip-heavy-jobs-on-docs-only-prs with one error code removed from docs/api/rest.rst, which format-lint must reject. Workflow and script changes count as documentation here so that the path runs. It will be closed without merging.