Repository navigation
fix(queue): force-stage verified patch paths and check command returncode (ticket-447) - #706
Merged
Conversation
…code (ticket-447)
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Validator approval after policy checks for exact head 45a164aee9e15545f571a3119e5a27eb2a981b44.
Ticket: ticket-447
Correlation ID: local-semcod-koru-pr-706-ticket-447
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Force-staging explicit verified paths with git add -f in commit_worktree and commit_on_main, plus a staging returncode check before commit in commit_worktree, matches the stated bug fix for gitignored paths (e.g. .planfile/). The new regression test covers the ignored-path commit_worktree path. Required checks (onedev/local-verify, standard packs / conformance) all PASS.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: e960b60e6316e557fb7a0034b9fef48317d2de09...45a164aee9e15545f571a3119e5a27eb2a981b44
Change digest: d55c3ed6c3be77855ba21666ad79a0da53c3181f2bc34c8c582675305b1494ab
Score: 44/100 (M), estimated 47 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":126,"base_sha":"e960b60e6316e557fb7a0034b9fef48317d2de09","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"d55c3ed6c3be77855ba21666ad79a0da53c3181f2bc34c8c582675305b1494ab","comparison":"e960b60e6316e557fb7a0034b9fef48317d2de09...45a164aee9e15545f571a3119e5a27eb2a981b44","deletions":4,"file_count":5,"files":["project/TICKETS.md","project/ticket-447/README.md","project/ticket-447/intent.json","src/koru/queue/workspace.py","tests/test_queue_workspace_retention.py"],"head_sha":"45a164aee9e15545f571a3119e5a27eb2a981b44","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":47,"within_budget":false},"impact":{"components":["project","src/koru","tests"],"files":["project/TICKETS.md","project/ticket-447/README.md","project/ticket-447/intent.json","src/koru/queue/workspace.py","tests/test_queue_workspace_retention.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-447"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-447: fix(queue): force-stage verified patch paths and check command returncode (ticket-447)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 47m</text></svg>DECISION D-447-3585
TICKET ticket-447
HEAD_SHA 45a164aee9e15545f571a3119e5a27eb2a981b44
CORRELATION_ID local-semcod-koru-pr-706-ticket-447
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["standard packs / conformance=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","standard packs / conformance=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":706,"head_sha":"45a164aee9e15545f571a3119e5a27eb2a981b44","base_sha":"e960b60e6316e557fb7a0034b9fef48317d2de09","diff_sha256":"fd8bc00d868ab97b1c7faddc01dabd497f770759d6b72f67055be7f1f49ff8a3"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-447/README.md","project/ticket-447/intent.json","src/koru/queue/workspace.py","tests/test_queue_workspace_retention.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"e960b60e6316e557fb7a0034b9fef48317d2de09","head_sha":"45a164aee9e15545f571a3119e5a27eb2a981b44","change_digest":"d55c3ed6c3be77855ba21666ad79a0da53c3181f2bc34c8c582675305b1494ab","score":44,"complexity":"M","estimated_minutes":47,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Contributor
There was a problem hiding this comment.
Validator approval after policy checks for exact head 45a164aee9e15545f571a3119e5a27eb2a981b44.
Ticket: ticket-447
Correlation ID: local-semcod-koru-pr-706-ticket-447
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Required checks passed. Explicit verified patch paths now use git add -f in commit_worktree and commit_on_main, with commit_worktree checking staging returncode before commit; regression covers ignored .planfile paths on the run branch.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: e960b60e6316e557fb7a0034b9fef48317d2de09...45a164aee9e15545f571a3119e5a27eb2a981b44
Change digest: d55c3ed6c3be77855ba21666ad79a0da53c3181f2bc34c8c582675305b1494ab
Score: 44/100 (M), estimated 47 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":126,"base_sha":"e960b60e6316e557fb7a0034b9fef48317d2de09","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"d55c3ed6c3be77855ba21666ad79a0da53c3181f2bc34c8c582675305b1494ab","comparison":"e960b60e6316e557fb7a0034b9fef48317d2de09...45a164aee9e15545f571a3119e5a27eb2a981b44","deletions":4,"file_count":5,"files":["project/TICKETS.md","project/ticket-447/README.md","project/ticket-447/intent.json","src/koru/queue/workspace.py","tests/test_queue_workspace_retention.py"],"head_sha":"45a164aee9e15545f571a3119e5a27eb2a981b44","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":47,"within_budget":false},"impact":{"components":["project","src/koru","tests"],"files":["project/TICKETS.md","project/ticket-447/README.md","project/ticket-447/intent.json","src/koru/queue/workspace.py","tests/test_queue_workspace_retention.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-447"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-447: fix(queue): force-stage verified patch paths and check command returncode (ticket-447)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 47m</text></svg>DECISION D-447-5582
TICKET ticket-447
HEAD_SHA 45a164aee9e15545f571a3119e5a27eb2a981b44
CORRELATION_ID local-semcod-koru-pr-706-ticket-447
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["standard packs / conformance=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","standard packs / conformance=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":706,"head_sha":"45a164aee9e15545f571a3119e5a27eb2a981b44","base_sha":"e960b60e6316e557fb7a0034b9fef48317d2de09","diff_sha256":"fd8bc00d868ab97b1c7faddc01dabd497f770759d6b72f67055be7f1f49ff8a3"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-447/README.md","project/ticket-447/intent.json","src/koru/queue/workspace.py","tests/test_queue_workspace_retention.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"e960b60e6316e557fb7a0034b9fef48317d2de09","head_sha":"45a164aee9e15545f571a3119e5a27eb2a981b44","change_digest":"d55c3ed6c3be77855ba21666ad79a0da53c3181f2bc34c8c582675305b1494ab","score":44,"complexity":"M","estimated_minutes":47,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
ifuri-validator-agent
Bot
deleted the
ticket/447-support-force-staging-and-add-returncode-check-for-verified-patch-paths-in-commit-worktree
branch
October 11, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git add -f -- <paths>incommit_worktreeandcommit_on_mainso that explicitly verified files ignored by broad repository.gitignorerules (such as.planfile/) can be committed to run branches.git addbefore invokinggit committo report staging failures immediately.tests/test_queue_workspace_retention.pyto verify behavior.