Skip to content

feat(queue): support pythonpath src and dot fallback in python-pytest builtin verify profile (ticket-448) - #707

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/448-support-pythonpath-src-and-dot-fallback-in-python-pytest-builtin-verify-profile
Oct 11, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/448-support-pythonpath-src-and-dot-fallback-in-python-pytest-builtin-verify-profile

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

  • Update BUILTIN_PROFILES["python-pytest"].command to python -m pytest -o pythonpath="src ." -q so that repositories with src/ layout can run tests in clean worktrees without needing prior editable installation.
  • Add test assertion in tests/test_queue_verify_profiles.py.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head d3f53ad08754714d076978fdaaddd886149b8389.

Ticket: ticket-448
Correlation ID: local-semcod-koru-pr-707-ticket-448
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Required checks passed. Builtin python-pytest profile correctly gains -o pythonpath="src ." so src-layout packages import in clean worktrees; unit test asserts the exact command. Ticket docs and intent match that change. TICKETS.md indexes ticket-447 rather than ticket-448—tracking inconsistency only, not a product defect.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 54490af40c001591304cb616cd66ec5617469716...d3f53ad08754714d076978fdaaddd886149b8389
Change digest: 297e99014d82f10470bc93ea8d5789594e0ed1b6648184d943ad5729c0766f41
Score: 44/100 (M), estimated 47 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":105,"base_sha":"54490af40c001591304cb616cd66ec5617469716","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"297e99014d82f10470bc93ea8d5789594e0ed1b6648184d943ad5729c0766f41","comparison":"54490af40c001591304cb616cd66ec5617469716...d3f53ad08754714d076978fdaaddd886149b8389","deletions":1,"file_count":5,"files":["project/TICKETS.md","project/ticket-448/README.md","project/ticket-448/intent.json","src/koru/queue/verify/profiles.py","tests/test_queue_verify_profiles.py"],"head_sha":"d3f53ad08754714d076978fdaaddd886149b8389","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":47,"within_budget":false},"impact":{"components":["project","src/koru","tests"],"files":["project/TICKETS.md","project/ticket-448/README.md","project/ticket-448/intent.json","src/koru/queue/verify/profiles.py","tests/test_queue_verify_profiles.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":13,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-448"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-448: feat(queue): support pythonpath src and dot fallback in python-pytest builtin verify profile (ticket-448)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 47m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-448-7657
TICKET ticket-448
HEAD_SHA d3f53ad08754714d076978fdaaddd886149b8389
CORRELATION_ID local-semcod-koru-pr-707-ticket-448
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","standard packs / conformance=PASS","governance / enforce=PASS","standard packs / conformance=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":707,"head_sha":"d3f53ad08754714d076978fdaaddd886149b8389","base_sha":"54490af40c001591304cb616cd66ec5617469716","diff_sha256":"0f31275fa2d4f706f1ecd6a52becf245c6f810ca013322541864b6254bce0b6b"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-448/README.md","project/ticket-448/intent.json","src/koru/queue/verify/profiles.py","tests/test_queue_verify_profiles.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"54490af40c001591304cb616cd66ec5617469716","head_sha":"d3f53ad08754714d076978fdaaddd886149b8389","change_digest":"297e99014d82f10470bc93ea8d5789594e0ed1b6648184d943ad5729c0766f41","score":44,"complexity":"M","estimated_minutes":47,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit febdb1e into main Oct 11, 2026
6 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/448-support-pythonpath-src-and-dot-fallback-in-python-pytest-builtin-verify-profile branch October 11, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant