fix: revalidate allocator preparation races under lock (ticket-217)

[tom-sapletta-com]

Summary

Ticket-217 / PLF-18410: handle optimistic allocator source changes by revalidating authoritative evidence after acquiring the mutation lock. Only typed source-change and missing-file races are deferred. Existing rebuild size bounds and allocation identity rules remain enforced; unrelated parser failures propagate.

Validation

• Regression before fix: 2 failed, 11 passed.
• After fix: 13 focused tests passed.
• Full suite: 1276 passed, 6 skipped.
• Changed Python files: Ruff passed.
• Managed governance: passed.

No data migration. Cold-start latency remains a separate followup. Publication requires exact-head OneDev and independent Validator approval.

[ifuri-validator-agent]

Validator approval after policy checks for exact head 694b1675cf53f45a10ba194beeb1718e6fb87072.

Ticket: ticket-217
Correlation ID: local-semcod-planfile-pr-265-ticket-217
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The change narrowly types optimistic source-change races, defers only those races and missing-file races to the existing locked authoritative fallback, and preserves propagation of unrelated parser errors. Regression tests cover successful fresh high-water revalidation, bounded failure for oversized changed sources without reservation writes, and unrelated parser failures. All protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: c0fcf9cb24c196e066946e133307c70863aeb9da...694b1675cf53f45a10ba194beeb1718e6fb87072
Change digest: 1b7f9f6dae7e4664c7862519cdae768a8518300efe294ab1fb9eb81fc28fb462
Score: 52/100 (M), estimated 59 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG

{"actual_change":{"additions":164,"base_sha":"c0fcf9cb24c196e066946e133307c70863aeb9da","binary_files":0,"categories":{"code":2,"configuration":1,"docs":2,"tests":1},"change_digest":"1b7f9f6dae7e4664c7862519cdae768a8518300efe294ab1fb9eb81fc28fb462","comparison":"c0fcf9cb24c196e066946e133307c70863aeb9da...694b1675cf53f45a10ba194beeb1718e6fb87072","deletions":5,"file_count":6,"files":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-217/README.md","project/ticket-217/intent.json","tests/test_allocator_preparation.py"],"head_sha":"694b1675cf53f45a10ba194beeb1718e6fb87072","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":3,"scope":2,"uncertainty":3,"validation":2},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":59,"within_budget":false},"impact":{"components":["planfile","project","tests"],"files":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-217/README.md","project/ticket-217/intent.json","tests/test_allocator_preparation.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":52,"split":{"parts":[{"estimated_minutes":17,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":17,"name":"Implement project","scope":["project"]},{"estimated_minutes":17,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-217"}

<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-217: fix: revalidate allocator preparation races under lock (ticket-217)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 89,56 79,85 54,78 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 59m</text></svg>

Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)

DECISION D-217-9842
TICKET ticket-217
HEAD_SHA 694b1675cf53f45a10ba194beeb1718e6fb87072
CORRELATION_ID local-semcod-planfile-pr-265-ticket-217
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / remote lifecycle=PASS","test (3.10)=PASS","freshness=PASS","ci-loop=PASS","governance / enforce=PASS","test (3.13)=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":265,"head_sha":"694b1675cf53f45a10ba194beeb1718e6fb87072","base_sha":"c0fcf9cb24c196e066946e133307c70863aeb9da","diff_sha256":"48802b63f69a62f0a230bed6b465576afb952ea987e217202d03bf2c5f3c50d7"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/core/allocator_sprints.py","planfile/core/store.py","project/TICKETS.md","project/ticket-217/README.md","project/ticket-217/intent.json","tests/test_allocator_preparation.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"c0fcf9cb24c196e066946e133307c70863aeb9da","head_sha":"694b1675cf53f45a10ba194beeb1718e6fb87072","change_digest":"1b7f9f6dae7e4664c7862519cdae768a8518300efe294ab1fb9eb81fc28fb462","score":52,"complexity":"M","estimated_minutes":59,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"