Conversation
Preserve variadic zip and merge and the explicit AsyncLazySequence constructor. Remove the conflicting Sequence.async extension and unused fixed-arity merge setup, repair test imports, and cover both modules together.
twittemb
force-pushed
the
fix/remove-swift-async-algorithms-overlaps
branch
from
October 3, 2026 10:44
ce1bf5d to
b015aa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing AsyncExtensions and Swift Async Algorithms together makes
Sequence.async, the fixed two- and three-inputzip/mergeAPIs, and theAsyncTimerSequencetype ambiguous. This change delegates.asyncand the fixed combiners to AsyncAlgorithms, removes their duplicate implementations and unused internal code, and renames AsyncExtensions’ buffered Date timer toAsyncBufferedTimerSequencewhile preserving its behavior.Preserve AsyncExtensions’ variadic
zip/mergeand explicitAsyncLazySequenceconstructor. Update the remaining tests to import AsyncAlgorithms where needed and explicitly exercise AsyncExtensions’ variadic operators. Add eight coexistence tests covering.async, Apple’s fixed overloads, AsyncExtensions’ four-input overloads, and both timer types. Rebase onto currentmain, retaining its subject and cancellation fixes.This is a breaking API migration: callers using the removed APIs must add the AsyncAlgorithms product dependency and import, and callers using the buffered Date timer must adopt its new name. README and changelog include migration guidance. The package now requires Swift 5.8 for the AsyncAlgorithms test dependency; the production target retains only its Collections dependency.
Validation on macOS with Swift 6.4:
git diff --checkpassed.