Repository navigation
python(feat): webhooks resource - #789
Merged
Merged
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-789/ Deployed from |
Brandon-Shippy
marked this pull request as ready for review
September 16, 2026 17:37
Brandon-Shippy
requested review from
alexluck-sift,
solidiquis and
wei-qlu
and removed request for
wei-qlu
September 16, 2026 17:37
wei-qlu
requested changes
Sep 20, 2026
wei-qlu
requested changes
Sep 20, 2026
Brandon-Shippy
force-pushed
the
python/webhooks-resource
branch
2 times, most recently
from
September 21, 2026 16:04
cecc9b0 to
a6ddb67
Compare
alexluck-sift
left a comment
alexluck-sift
left a comment
Collaborator
There was a problem hiding this comment.
Audit pass on the webhooks surface. Nine comments, five of them nits. The first one is the only thing I'd call blocking, and it's a reviewer conflict rather than anything you did wrong.
alexluck-sift
previously approved these changes
Sep 25, 2026
alexluck-sift
self-requested a review
September 26, 2026 00:26
alexluck-sift
previously approved these changes
Sep 26, 2026
Brandon-Shippy
dismissed stale reviews from wei-qlu and alexluck-sift
via
September 26, 2026 02:18
9094296
Brandon-Shippy
force-pushed
the
python/webhooks-resource
branch
from
September 26, 2026 02:18
b49c91d to
9094296
Compare
Brandon-Shippy
enabled auto-merge (squash)
September 26, 2026 02:19
Brandon-Shippy
force-pushed
the
python/webhooks-resource
branch
from
September 26, 2026 02:29
9094296 to
d3a014b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a webhooks resource to
sift_client, and lets a rule call a webhook when it is violated.Webhook and all associated classes and enums are made.
Implements get, list_, find, create, update, archive/unarchive, send_test_request
Validation