Repository navigation
rust(docs): warn that unscoped list_channels name searches can time out - #827
Merged
alexa-sift merged 3 commits intoOct 13, 2026
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bijan-sift
reviewed
Oct 13, 2026
bijan-sift
left a comment
There was a problem hiding this comment.
is there a way to confirm this works?
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
@bijan-sift fair question. The linked azimuth PR has more integration-type tests that I originally included, but I added a test here as well. Lmk your thoughts |
bijan-sift
previously approved these changes
Oct 13, 2026
alexa-sift
marked this pull request as ready for review
October 13, 2026 20:04
…t_channels-guidance-that-unscoped-name-searches # Conflicts: # rust/crates/sift_mcp/src/tool/channels/test.rs
bijan-sift
approved these changes
Oct 13, 2026
alexa-sift
enabled auto-merge (squash)
October 13, 2026 22:06
alexa-sift
deleted the
eng-15732-warn-in-list_channels-guidance-that-unscoped-name-searches
branch
October 13, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In large orgs,
list_channelsname searches without anasset_idscope scan every channel and can hit the client request timeout. Agents then retry the same broad filter. Thelist_channelsguidance now says to resolve candidate assets withlist_assetsfirst, search each asset by name, and treat a timeout as a too-broad filter rather than bad parameters.Verification
cargo fmt -p sift_mcp -- --check,cargo clippy -p sift_mcp --all-targets --all-features(no new warnings)cargo test -p sift_mcp(581 pass), including a new test that thelist_channelsdescription carries the timeout guidancetools/listcheck: ransift-cli mcpfrom a local build of this branch (placeholder profile, no backend calls) and read thelist_channelsdescription over stdio. All 42 tools listed. The new bullet comes through with"unescaped and no\"or literal\n. Diffed against sift-cli 0.7.2, the only change is the three new lines: