Repository navigation
rust(docs): name asset_ids in list_runs output and fix list_channels asset fields - #828
Merged
Merged
Conversation
…nels Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexa-sift
marked this pull request as ready for review
October 13, 2026 20:05
bill-sift
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
list_runsdescription said each run includesasset_id/asset_name, but runs carryasset_idsand no asset name. Agents that projected those fields withfieldsgot nothing back and had to list runs again. The description now namesasset_ids, drops "annotation state" (a filter-only field), and says to resolve names withlist_assets. Thefieldshelp now warns that filter fields are not output fields.list_channelshad the same problem: it promisedasset_nameand "units". It now namesasset_idandunit_idand points tolist_assetsfor the asset name.New tests confirm
list_runsreturnsasset_idsandlist_channelsreturnsasset_id/unit_idwhen requested withfields, and thatasset_namelands inunmatched_fields.Verification
cargo fmt -p sift_mcp,cargo clippy -p sift_mcp --all-targets --all-features(no new warnings),cargo test -p sift_mcp(580 pass)