Skip to content

rust(docs): name asset_ids in list_runs output and fix list_channels asset fields - #828

Merged
alexa-sift merged 2 commits into
mainfrom
eng-15729-fix-list-runs-output-description
Oct 13, 2026
Merged

alexa-sift merged 2 commits into
mainfrom
eng-15729-fix-list-runs-output-description

Conversation

@alexa-sift

@alexa-sift alexa-sift commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

The list_runs description said each run includes asset_id/asset_name, but runs carry asset_ids and no asset name. Agents that projected those fields with fields got nothing back and had to list runs again. The description now names asset_ids, drops "annotation state" (a filter-only field), and says to resolve names with list_assets. The fields help now warns that filter fields are not output fields.

list_channels had the same problem: it promised asset_name and "units". It now names asset_id and unit_id and points to list_assets for the asset name.

New tests confirm list_runs returns asset_ids and list_channels returns asset_id/unit_id when requested with fields, and that asset_name lands in unmatched_fields.

Verification

  • cargo fmt -p sift_mcp, cargo clippy -p sift_mcp --all-targets --all-features (no new warnings), cargo test -p sift_mcp (580 pass)

alexa-sift and others added 2 commits October 13, 2026 10:41
…nels

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alexa-sift
alexa-sift requested a review from bill-sift October 13, 2026 20:05
@alexa-sift
alexa-sift marked this pull request as ready for review October 13, 2026 20:05
@alexa-sift
alexa-sift requested a review from solidiquis October 13, 2026 20:19
@alexa-sift
alexa-sift merged commit bcdfa28 into main Oct 13, 2026
22 checks passed
@alexa-sift
alexa-sift deleted the eng-15729-fix-list-runs-output-description branch October 13, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants