Mark a respelled copy's morpheme breakdown stale (#381) - #393
Open
alex-rawlings-yyc wants to merge 3 commits into
Open
alex-rawlings-yyc wants to merge 3 commits into
alex-rawlings-yyc wants to merge 3 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (30)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change marks copied multi-morpheme breakdowns stale when analyses are reapplied to respelled text. Stale state flows through catalog rows, merges, and suggestions. Editors style stale breakdowns and allow unchanged forms to be confirmed. Re-splitting or deleting a breakdown also clears its stale mark. ChangesStale Morpheme Breakdown Handling
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
actor Reader
participant AnalysisStore
participant AnalysisSlice
participant TokenChip
participant MorphemeEditor
Reader->>AnalysisStore: Reapply stale analysis
AnalysisStore->>AnalysisSlice: Apply reapplication
AnalysisSlice-->>TokenChip: Stale approved analysis ID
TokenChip->>MorphemeEditor: Provide confirmation callback
Reader->>MorphemeEditor: Choose Done without editing
MorphemeEditor->>AnalysisStore: Confirm analysis morphemes
AnalysisStore->>AnalysisSlice: Dispatch confirmation and save analysis
AnalysisSlice-->>TokenChip: Clear stale mark
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The stale-breakdown change appears ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
alex-rawlings-yyc
marked this pull request as ready for review
October 2, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #381. Part of #349.
Applying a stale analysis to a word spelled differently copied a breakdown of several morphemes with its forms unchanged, so
reciev-edshowed under "received" as if it fit. The copy's breakdown is now marked stale and keeps its morpheme glosses and lexicon links. It shows in stale styling in the word's box, the catalog, the merge panel and suggestion rows, and screen-reader labels say it was split from a different spelling.The mark belongs to the analysis rather than each occurrence, since the forms are wrong wherever it is used, and it is not part of analysis identity. Done on the unchanged forms keeps the breakdown and clears the mark for every word using it; while the forms are unchanged, the editor says what Done will do. Re-splitting or removing the breakdown also clears it, in the view or the catalog. A re-split in the view forks a shared analysis as before, so the other words keep the mark. Suggestions still offer a stale-marked analysis, and accepting one links it as it stands.
When an edit makes two analyses identical, the survivor stays stale only if both were. A merge's breakdown is stale when it is taken unedited from a stale analysis.
Checked in the running app.
This change is
Summary by CodeRabbit