Skip to content

Set view-option defaults and retire five toggles (#386) - #394

Merged
alex-rawlings-yyc merged 2 commits into
mainfrom
feat/386-view-option-defaults
Oct 7, 2026
Merged

alex-rawlings-yyc merged 2 commits into
mainfrom
feat/386-view-option-defaults

Conversation

@alex-rawlings-yyc

@alex-rawlings-yyc alex-rawlings-yyc commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Closes #386.

Continuous scroll now starts off. Show morphology starts on, except in Platform.Bible's simple interface mode or when the mode can't be read. Show free translation starts on only when the analysis already holds a free translation. That check uses the analysis as it was loaded, so clearing the last translation mid-session doesn't hide its input. In the Paratext 9 import view, the view options wait for the import's analysis to load. Each setting is still saved per project, which covers the issue's request to keep changes between sessions.

Show morphology and Show free translation ship with an 'auto' default. That lets the view tell a setting the user never chose from one they turned off, and pick the default from context. A null default isn't an option because the C# project data provider throws on it. Resetting either setting returns it to 'auto' and the view to its default. Platform.Bible's Project Settings dialog picks each control from the stored value's type, so it shows auto in a text box until the setting is first chosen. It already shows True/False text boxes for any of our toggles Paratext has stored.

Five toggles are gone, each fixed at the value the issue gives. The verse gutter always shows, phrase controls show on every phrase, and suggestions always show. Link buttons show only within the active segment, so the disabled-link tooltip at a segment boundary is gone too. The wheel scrolls the strip freely: the wheel mode that stepped the focus is deleted, and the Scroll to focused phrase button always shows.

With the gutter always on, segment cards still mark any verse that starts partway through the card inline, such as verse 3 in a merged 2–3 card. The gutter gives a card's range but not where each verse begins in it. The gutter is no longer hidden from screen readers, since it is now the only place a card's first verse number appears.

user-questions.md drops the questions this settles: the Show suggestions demo toggle and the choice of wheel mode.

Checked in the running app.


This change is Reviewable

@alex-rawlings-yyc alex-rawlings-yyc self-assigned this Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5044eb04-64c7-4555-a319-4a0b3930cf95
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alex-rawlings-yyc
alex-rawlings-yyc marked this pull request as ready for review October 2, 2026 20:57

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This review was assisted by Claude Opus 5.5.

@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the feat/386-view-option-defaults branch from 2e35403 to bdbaeca Compare October 6, 2026 17:38

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase verified, LGTM

This review was assisted by Claude Opus 5.5.

@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the feat/386-view-option-defaults branch from bdbaeca to 1bc5760 Compare October 6, 2026 18:49
@alex-rawlings-yyc
alex-rawlings-yyc merged commit 41ddced into main Oct 7, 2026
9 checks passed
@alex-rawlings-yyc
alex-rawlings-yyc deleted the feat/386-view-option-defaults branch October 7, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default interlinear view options

2 participants