Repository navigation
Set view-option defaults and retire five toggles (#386) - #394
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
marked this pull request as ready for review
October 2, 2026 20:57
jasonleenaylor
approved these changes
Oct 6, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
LGTM
This review was assisted by Claude Opus 5.5.
alex-rawlings-yyc
force-pushed
the
feat/386-view-option-defaults
branch
from
October 6, 2026 17:38
2e35403 to
bdbaeca
Compare
jasonleenaylor
approved these changes
Oct 6, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Rebase verified, LGTM
This review was assisted by Claude Opus 5.5.
alex-rawlings-yyc
force-pushed
the
feat/386-view-option-defaults
branch
from
October 6, 2026 18:49
bdbaeca to
1bc5760
Compare
jasonleenaylor
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386.
Continuous scroll now starts off. Show morphology starts on, except in Platform.Bible's simple interface mode or when the mode can't be read. Show free translation starts on only when the analysis already holds a free translation. That check uses the analysis as it was loaded, so clearing the last translation mid-session doesn't hide its input. In the Paratext 9 import view, the view options wait for the import's analysis to load. Each setting is still saved per project, which covers the issue's request to keep changes between sessions.
Show morphology and Show free translation ship with an
'auto'default. That lets the view tell a setting the user never chose from one they turned off, and pick the default from context. A null default isn't an option because the C# project data provider throws on it. Resetting either setting returns it to'auto'and the view to its default. Platform.Bible's Project Settings dialog picks each control from the stored value's type, so it showsautoin a text box until the setting is first chosen. It already showsTrue/Falsetext boxes for any of our toggles Paratext has stored.Five toggles are gone, each fixed at the value the issue gives. The verse gutter always shows, phrase controls show on every phrase, and suggestions always show. Link buttons show only within the active segment, so the disabled-link tooltip at a segment boundary is gone too. The wheel scrolls the strip freely: the wheel mode that stepped the focus is deleted, and the Scroll to focused phrase button always shows.
With the gutter always on, segment cards still mark any verse that starts partway through the card inline, such as verse 3 in a merged 2–3 card. The gutter gives a card's range but not where each verse begins in it. The gutter is no longer hidden from screen readers, since it is now the only place a card's first verse number appears.
user-questions.mddrops the questions this settles: the Show suggestions demo toggle and the choice of wheel mode.Checked in the running app.
This change is