Lead a PT9 import with its most-glossed language (#338) - #396
Open
alex-rawlings-yyc wants to merge 5 commits into
Open
alex-rawlings-yyc wants to merge 5 commits into
alex-rawlings-yyc wants to merge 5 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
force-pushed
the
fix/338-pt9-lead-language
branch
from
October 5, 2026 17:45
7f2fa62 to
190dc62
Compare
|
Not sure what to say. My problem was resolved by closing the interlinear window and reopening it. I cannot reproduce it again. |
Contributor
Author
|
@rdeblois1960 No worries. Let us know if it does come up again |
alex-rawlings-yyc
force-pushed
the
fix/338-pt9-lead-language
branch
from
October 5, 2026 22:45
21af8fa to
d6f1650
Compare
alex-rawlings-yyc
marked this pull request as ready for review
October 6, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #338.
Summary
encomes first but covers only LUK, so nearly every gloss showed blank. The languages are now sorted by how many tokens each one glosses, with ties kept in file order. The view and Copy to editable both use the first language, so both now get the main one.InterlinearProject.analysisLanguagesnow says the first tag is the language glosses are shown and edited in.Existing imports pick up the new order the next time they sync.
Out of scope: the import prompt still doesn't say the import opens read-only. A word with no imported gloss still has no gloss field until the import is copied to an editable project.
Test plan
swh, en, English, and 96.6% of approved tokens have a Swahili glossThis change is