Skip to content

Lead a PT9 import with its most-glossed language (#338) - #396

Open
alex-rawlings-yyc wants to merge 5 commits into
mainfrom
fix/338-pt9-lead-language
Open

alex-rawlings-yyc wants to merge 5 commits into
mainfrom
fix/338-pt9-lead-language

Conversation

@alex-rawlings-yyc

@alex-rawlings-yyc alex-rawlings-yyc commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Closes #338.

Summary

  • A PT9 import listed its gloss languages in the order their files were found, but the view shows glosses in the first language only. In Pimbwe, en comes first but covers only LUK, so nearly every gloss showed blank. The languages are now sorted by how many tokens each one glosses, with ties kept in file order. The view and Copy to editable both use the first language, so both now get the main one.
  • InterlinearProject.analysisLanguages now says the first tag is the language glosses are shown and edited in.

Existing imports pick up the new order the next time they sync.

Out of scope: the import prompt still doesn't say the import opens read-only. A word with no imported gloss still has no gloss field until the import is copied to an editable project.

Test plan

  • Unit tests: a language that glosses more tokens but is listed later comes first, a language whose books converted nothing goes last, and tied languages keep file order; 100% coverage
  • Re-sync Pimbwe: languages are swh, en, English, and 96.6% of approved tokens have a Swahili gloss
  • Open Pimbwe, accept the import offer, then Open: Swahili glosses show in PHP, ROM and LUK

This change is Reviewable

@alex-rawlings-yyc alex-rawlings-yyc self-assigned this Oct 5, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 27255689-84e3-4d25-b5ed-e1fa31ae91fe
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rdeblois1960

Copy link
Copy Markdown

Not sure what to say. My problem was resolved by closing the interlinear window and reopening it. I cannot reproduce it again.

@alex-rawlings-yyc

Copy link
Copy Markdown
Contributor Author

@rdeblois1960 No worries. Let us know if it does come up again

@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the fix/338-pt9-lead-language branch from 21af8fa to d6f1650 Compare October 5, 2026 22:45
@alex-rawlings-yyc
alex-rawlings-yyc marked this pull request as ready for review October 6, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After importing interlinear data from Paratext 9, gloss field no longer visible

2 participants