Repository navigation
Switch the displayed analysis language from the toolbar (#291) - #397
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
force-pushed
the
feat/291-analysis-language-switch
branch
from
October 6, 2026 17:50
1691077 to
dca5e13
Compare
alex-rawlings-yyc
marked this pull request as ready for review
October 6, 2026 18:12
jasonleenaylor
approved these changes
Oct 7, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Looking ahead, not for this PR: we may want to show more than one analysis language at once at some point, as FieldWorks does, perhaps as an option alongside the picker.
This review was assisted by Claude Opus 5.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #291.
When the open project has more than one analysis language, a language picker appears in the toolbar beside View options. Glosses and free translations are read and written in the picked language, in the draft and in a read-only Paratext 9 import alike. Switching keeps the analysis store, so in-progress edits survive it, as does the catalog's scroll position unless the catalog is sorted by gloss or filtered to missing glosses.
The choice is kept in tab state, separately for each import and once for the draft. It falls back to the first listed language when the project no longer lists the chosen one. Each option shows the language name beside its tag, since distinct tags can share a name: Pimbwe lists both
enandEnglish. A tag repeated in the New or Project Info language field is kept once.Checked in the running app on Bungu's draft (en, fr) and PIA's import (es, fr). The picker staying hidden for a single language is covered by tests only.
PIA's import in Spanish, with the picker open:
The same verses in French:
This change is