Headings at the start of chapters do not get relocated

[pmachapman]

I'm not sure this can be fixed.

Given the book Malachi with a source with the English Versification, and a target with the Septuagint Versification, most references will be converted correctly, e.g. MAL 4:1 -> MAL 3:19, and Serval will use these in the Pretranslations stored in Mongo. i.e.:

{
  "textId": "MAL",
  "sourceRefs": ["MAL 4:1"],
  "targetRefs": ["MAL 3:19"],
  "refs": ["MAL 3:19"],
  "translation": "“For behold, the day is coming, burning like a furnace, when all the arrogant and every evildoer will be stubble; the day is coming when I will set them ablaze,” says the LORD of Hosts. “Not a root or branch will be left to them.”",
}

However, if there were headings at the start of chapter 4, VerseRef.ChangeVersification will not convert the source reference to a suitable target reference:

{
  "textId": "MAL",
  "sourceRefs": ["MAL 4:0/1:s1"],
  "targetRefs": ["MAL 4:0/1:s1"],
  "refs": ["MAL 4:0/1:s1"],
  "translation": "The Day of the LORD",
}

Which means that the final USFM outputted by Serval using the UpdateUsfmParserHandler will lose the headings, i.e.:

\v 18 So you will again distinguish between the righteous and the wicked, between those who serve God and those who do not.”
\s1 
\r 
\m
\v 19 “For behold, the day is coming, burning like a furnace, when all the arrogant and every evildoer will be stubble; the day is coming when I will set them ablaze,” says the LORD of Hosts. “Not a root or branch will be left to them.” 

I'm not sure what we can do? Check if the next verse is being relocated, and move any headings to the verse before that one???

[Enkidu93]

Hmm, sorry for just replying. I don't know how I missed this issue. I think we can fix this. What this really comes down to is handling verse 0s more reasonably when dealing with ScriptureRefs. I think we could just do like you say: If a scripture ref is a verse 0, add one, convert, etc.

[pmachapman]

@Enkidu93 Do you want me to give you access to the projects I used to recreate this so you can test at your end? I've had it happen with a normal build and Echo.

[Enkidu93]

@Enkidu93 Do you want me to give you access to the projects I used to recreate this so you can test at your end? I've had it happen with a normal build and Echo.

Sure! That'd be great, thank you!

[pmachapman]

@Enkidu93 I have added you to the ATE - Alignment Test English, ATG - Alignment Test Greek, and ATH - Alignment Test Hebrew projects on the Paratext Production servers. (I also have them on PT dev, but I don't think you use that version?)