Skip to content

feat(oci): add native Notifications integration - #7545

Open
BillLeoutsakosvl346 wants to merge 1 commit into
feat/oci-foundationfrom
investigate/oci-notifications-integration
Open

feat(oci): add native Notifications integration#7545
BillLeoutsakosvl346 wants to merge 1 commit into
feat/oci-foundationfrom
investigate/oci-notifications-integration

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add native OCI Notifications with 16 publishing and topic/subscription management tools, plus credential-bound topic and subscription selectors.
  • Reuse the OCI API-key service account and signed client from feat(oci): add native foundation #7444. Discover subscription/publishing endpoints through authenticated GetTopic.
  • Support tags, conditional updates, compartment moves, topic locks, and confirmation resending. Recipient confirmation remains external; direct SMS and inbound Sim triggers are excluded.
  • Publish once with a 64,000-byte serialized request cap. Acceptance is not delivery; whole-block retries can duplicate an ambiguously completed publication.

Stack

  • Independent child of feat(oci): add native foundation #7444; base: feat/oci-foundation.
  • Foundation revision: 3fa59e758f5d282e95978aca7482a91a4f3dcee5.
  • No foundation, shared client, retry infrastructure, webhook infrastructure, generator, or CI workflow changes.

Type of Change

  • New integration

Testing

  • Independent validate-integration/validate-selector static review completed, including combined foundation execution and authorization paths.
  • Added focused operation, adapter, and selector tests. Generated tool metadata, integration docs/catalog, deployment catalog, and docs manifest.
  • Tests, type checks, lint/audits, and build run on GitHub only. Test and Build is manually dispatched on this branch because automatic CI excludes foundation-based PRs.
  • Test and Build passed for 2b9e91324f1e1b64b04dc296a7ac9feac1915c06: lint/audits, docs sync, workspace type checks, all three test shards, migration consistency, and application build. All 45 focused Notifications tests passed.
  • No tenant operations or local tests/builds/checks performed.

Checklist

  • Self-reviewed changes and completed independent static review
  • Reused existing integration patterns and NetSuiteIcon
  • Added focused regression coverage and generated artifacts
  • GitHub validation passing

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 6, 2026 12:52am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the investigate/oci-notifications-integration branch from e410611 to 862ca82 Compare September 6, 2026 00:41
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a native OCI Notifications integration backed by the existing OCI API-key service account and signed client.

  • Provides 16 tools for publishing and managing topics, subscriptions, compartments, tags, locks, and confirmations.
  • Adds credential-bound topic and subscription selectors with authenticated endpoint discovery.
  • Registers the integration across blocks, OAuth configuration, tool operations, documentation, generated metadata, and deployment configuration.
  • Adds focused operation, adapter, selector, and manifest coverage.
  • The only change since the previous review assigns OCI Notifications its distinct provider identity while retaining the shared OCI API-key credential provider.

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule violations identified.

No new actionable issue remains. The provider-ID correction preserves credential discovery through the shared OCI API-key service-account provider. BillLeoutsakosvl346 resolved the earlier update-description and selector-prerequisite threads after documenting the intentional contracts and accepted shared-framework limitations; the duplicate description finding was conceded by Greptile. BillLeoutsakosvl346 also resolved the retryability thread after explaining that retries occur inside the OCI client and the response marker is not currently consumed by workflow-level retry handling.

Important Files Changed

Filename Overview
apps/sim/lib/oauth/oauth.ts Registers OCI Notifications with a distinct service provider ID while continuing to share the OCI API-key service-account credential provider.
apps/sim/lib/internal/oci-notifications/operations.ts Implements signed OCI Notifications topic, subscription, lock, compartment, confirmation, and publication operations.
apps/sim/lib/internal/oci-notifications/execute-tool.ts Validates and dispatches OCI Notifications operations through the shared OCI client.
apps/sim/lib/internal/oci-notifications/endpoints.ts Discovers authenticated publishing and subscription endpoints through GetTopic.
apps/sim/blocks/blocks/oci_notifications.ts Defines the integration block, operation-specific inputs, selectors, parsing, and adapter mappings.
apps/sim/lib/selectors/server/providers/oci-notifications.ts Implements credential-bound topic and subscription selector providers.
apps/sim/lib/internal/oci-notifications/schema.ts Defines request validation contracts for all supported OCI Notifications operations.
apps/docs/content/docs/integrations/oci_notifications.mdx Documents all integration operations, inputs, outputs, endpoint discovery, and publication retry caveats.

Sequence Diagram

sequenceDiagram
    participant W as Sim Workflow
    participant B as OCI Notifications Block
    participant C as Shared OCI Signed Client
    participant T as OCI GetTopic Endpoint
    participant N as OCI Notifications Endpoint

    W->>B: Invoke selected operation
    B->>C: Load OCI API-key credential
    alt Topic-native operation
        C->>N: Send signed request
    else Subscription or publish operation
        C->>T: GetTopic
        T-->>C: Authenticated API endpoint
        C->>N: Send signed request to discovered endpoint
    end
    N-->>B: Status, request ID, and operation result
    B-->>W: Tool response
Loading

Reviews (4): Last reviewed commit: "feat(oci): add native Notifications inte..." | Re-trigger Greptile

Comment thread apps/sim/tools/oci_notifications/update_topic.ts
Comment thread apps/sim/blocks/blocks/oci_notifications.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Comment thread apps/sim/lib/internal/oci-notifications/execute-tool.ts
Comment thread apps/sim/tools/oci_notifications/update_topic.ts
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the investigate/oci-notifications-integration branch from f91e1c3 to 2b9e913 Compare September 6, 2026 00:50
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant