feat(oci-compute): add native Compute integration - #7549
feat(oci-compute): add native Compute integration#7549BillLeoutsakosvl346 wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryAdds a native OCI Compute integration backed by the existing OCI signing-key credential family.
Confidence Score: 5/5The PR appears safe to merge; no actionable new issue or outstanding previous finding remains. The distinct Compute service identity remains compatible with the shared OCI signing-key credential provider, base OCI retains canonical family resolution, and all previous findings are fixed, conceded, or manually resolved.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/oauth/oauth.ts | Assigns OCI Compute a distinct service identity while retaining the shared signing-key credential family and canonical base-OCI ordering. |
| apps/sim/lib/internal/oci-compute/projection-contract.test.ts | Adds regression coverage for Compute identity, signing-key reuse, canonical family resolution, selector context, and projections. |
| apps/sim/lib/internal/oci-compute/operations.ts | Implements OCI Compute request construction, operation dispatch, pagination metadata, retry identity, and stable resource projections. |
| apps/sim/lib/internal/oci-compute/schema.ts | Defines bounded validation and cross-field requirements for the supported Compute operations. |
| apps/sim/lib/selectors/server/providers/oci-compute.ts | Implements credential-aware, bounded OCI resource discovery for Compute block inputs. |
| apps/sim/blocks/blocks/oci_compute.ts | Defines the workflow-facing Compute block, operation-specific inputs, selector contexts, tool mappings, and outputs. |
| apps/sim/tools/registry.ts | Registers the complete OCI Compute tool set in the executable tool registry. |
| packages/deployment-config/src/integrations.json | Adds generated deployment catalog metadata for the OCI Compute integration. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Workflow[OCI Compute workflow block] --> Tool[Registered Compute tool]
Selector[Bounded resource selector] --> ComputeRuntime[OCI Compute internal runtime]
Tool --> ComputeRuntime
Credential[Shared OCI signing-key credential] --> CredentialFamily[oci-api-key-service-account]
CredentialFamily --> ComputeRuntime
ComputeRuntime --> OCI[OCI Core REST APIs]
OCI --> Projection[Stable projected workflow output]
Projection --> Workflow
Reviews (8): Last reviewed commit: "fix(oci-compute): register a distinct se..." | Re-trigger Greptile
|
@greptile please review b3388af. GitHub caught the duplicate primary service ID: Compute now has providerId oci_compute while retaining the shared oci-api-key-service-account credential family. The existing OCI family entry remains first, with regression coverage for identity, credential reuse, and unchanged family resolution. |
Summary
feat/oci-foundation,3fa59e758f5d282e95978aca7482a91a4f3dcee5). The complete delta contains Compute implementation, registration bookkeeping, focused tests, and generated artifacts.Type of Change
Testing
GitHub Test and Build passed for
b3388af39a8ce6d74f877f98eb6412bad2478f10: lint, repository audits, generated-doc synchronization, all workspace type checks, all three app test shards, other workspace tests, and Build App.Independent integration/selector source review covered the Compute delta and relevant foundation behavior against official Oracle schemas and Sim precedents. The reviewer agrees on the final revision with no unresolved actionable integration defects. Greptile reports 5/5 for the final revision; all review threads have reasoned dispositions and are resolved.
Fifty focused Compute tests cover launch/configuration variants, lifecycle requests, retry identity, pagination, projections, and credential/context wiring through mocks. No local tests, builds, lint, type checks, or live OCI requests were run.
Workflow-dispatch diff audits use
HEAD~1; the full foundation-to-Compute file and commit delta was inspected separately. The existing non-blocking dependency security audit reports advisories in unchanged dependencies; dependency changes remain outside this PR.Limitations
Operations return current resource/status results without provisioning waiters. Capacity reports do not reserve capacity. Token-supporting requests use bounded retries and stable invocation identity where available; deletion and termination are single-attempt at the OCI request layer. User-enabled workflow retries can replay unkeyed mutations, including termination; operators must inspect ambiguous outcomes before resubmitting.
Networking, storage provisioning, load balancing, Kubernetes, and advanced Compute administration remain outside this integration. The foundation and shared execution behavior are unchanged.
Scope note
The only additional file beyond the accepted tree is
apps/sim/lib/selectors/manifest.test.ts: update its exhaustive selector inventory and audited-provider lists for nine new registrations. No generic behavior or audit baseline was changed.Checklist