Skip to content

v0.8.43: search improvements - #7954

Merged
waleedlatif1 merged 8 commits into
mainfrom
staging
Sep 18, 2026
Merged

waleedlatif1 merged 8 commits into
mainfrom
staging

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

waleedlatif1 and others added 8 commits September 17, 2026 14:39
* fix(embeddings): preserve safe provider failure diagnostics

* fix(embeddings): classify aggregated batch failures
…7944)

* fix(knowledge): share compact vector retrieval across access scopes

* fix(knowledge): align search fixtures with shared retrieval

* fix(knowledge): preserve recall within bounded reranking

* fix(knowledge): validate bounded compact scan plans

* fix(knowledge): batch workspace search refills
)

* fix(landing): repair public links and streamline landing previews

* fix(landing): remove obsolete tracking and preserve preview interactions

* fix(landing): remove Sakana from featured footer providers
…unks (#7947)

* improvement(file-search): publish complete indexes in bounded text chunks

* fix(file-search): address compatibility and extraction review findings

* fix(file-search): preserve spreadsheet extraction cancellation

* fix(file-search): align agent content reads with indexed lines

* fix(file-search): cancel abandoned text reads
…re (#7950)

* fix(mailer): enforce Max access and preserve inbox resources on failure

* fix(mailer): bound deletion polling separately from failure retries

* fix(mailer): expedite rollback after activation failure
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner September 18, 2026 00:23
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 18, 2026 12:23am UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit 93e4e13 into main Sep 18, 2026
52 checks passed
@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The implementation appears behaviorally safe, but the explicit repository import-order requirement must be satisfied before merging.

Findings

  1. P2 External Import Is Misordered

Summary

This release improves knowledge and workspace-file search, preserves safe embedding diagnostics, hardens inbox lifecycle cleanup and entitlement handling, adjusts organization-search transitions, and streamlines landing-page resources.

  • Publishes complete workspace-file indexes as bounded, atomically activated chunks.
  • Shares compact vector retrieval across knowledge-access scopes.
  • Keeps organization search centered until results arrive and preserves layout state during refinements.
  • Adds durable compensation for inbox provisioning and cleanup failures.
  • Updates landing previews, public links, consent resources, and activity labels.
  • One repository import-order violation remains.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  F[Workspace file revision] --> E[Complete text extraction]
  E --> P{Eligible and within limits?}
  P -- No --> S[Mark revision skipped or failed]
  P -- Yes --> B[Create fenced search build]
  B --> C[Write bounded text chunks]
  C --> V[Validate chunk count and bytes]
  V --> A[Atomically publish ready revision]
  A --> Q[Search current ready chunks]
  Q --> R[Return matching logical lines and coverage]
Loading

Reviews (1) · Last reviewed commit: "fix(openai): preserve optional Responses..."

Comment on lines 3 to +5
import { type ReactNode, useEffect, useRef, useState } from 'react'
import { ChipChevronDown, chipContentLabelClass, chipVariants, cn } from '@sim/emcn'
import dynamic from 'next/dynamic'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 External Import Is Misordered

The new next/dynamic import appears after the @sim/emcn UI import. This violates the repository's required import order: React and core libraries, then external libraries, then UI components. This repository requirement must be satisfied before merging.

Suggested change
import { type ReactNode, useEffect, useRef, useState } from 'react'
import { ChipChevronDown, chipContentLabelClass, chipVariants, cn } from '@sim/emcn'
import dynamic from 'next/dynamic'
import { type ReactNode, useEffect, useRef, useState } from 'react'
import dynamic from 'next/dynamic'
import { ChipChevronDown, chipContentLabelClass, chipVariants, cn } from '@sim/emcn'

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants