Skip to content

fix(search): restore submission layout and delay filters - #7959

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-submit-layout
Sep 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-submit-layout

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Move the search field to the top immediately on submission and remove the result-dependent layout wrapper.
  • Reveal filters after a complete response or useful partial results, then preserve controls and focus during refinements.
  • Preserve centered heading text and activate scroll-edge tracking when the results view mounts.

Type of Change

  • Bug fix

Testing

  • 51 focused search and query-cache tests passed, including submission, filtering, retries, empty and partial results, cancellation, access-scope changes, and scroll edges.
  • Verified submission, source/date refinements, focus, and returning to the empty search in the local browser.
  • Type-check, cleanup, lint, and repository audits passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 18, 2026 3:53am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the changed layout, filter lifecycle, and scroll tracking supported by focused transition tests.

Summary

This PR restores the organization search submission layout and adjusts filter visibility across search transitions.

  • Docks the search field immediately when a nonempty URL-backed query is submitted.
  • Initializes result-scroll edge tracking when the results view mounts.
  • Delays filters until complete or useful partial results exist, while retaining them during refinements and retries.
  • Extends focused tests for submission, filter persistence, retries, partial responses, empty results, and scroll fades.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Centered empty search] -->|Submit query| B[Docked search field]
  B --> C[Pending response]
  C -->|Complete response| D[Show filters and results or empty state]
  C -->|Useful partial results| E[Show filters and partial results]
  C -->|Empty partial response or failure| F[Keep filters hidden]
  D -->|Refine filters or retry| G[Preserve controls and focus]
  E -->|Retry| G
  G --> D
Loading

Reviews (1) · Last reviewed commit: "fix(search): restore submission layout a..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 8396028 into staging Sep 18, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-submit-layout branch September 18, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant