Consolidate EMCN controls and redundant styling options by BillLeoutsakosvl346 · Pull Request #7998 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-19T00:53:27Z

Consolidates overlapping EMCN controls while preserving product layouts, selection values, form behavior, and marketing treatments.

Make ChipSelect the single menu-selection API, supporting rich labels, grouped/searchable options, typed single/multiple selection, trigger refs, and field accessibility. Preserve caller-specific menu width, modal behavior, empty-selection semantics, and selection indicators.
Share one Radix segmented-control implementation through ChipButtonGroup and its ChipSwitch adapter. Remove redundant styling dimensions and unused Button, Checkbox, and Badge choices.
Exclude inherited generic sizing props from specialized action buttons that own their geometry.
Use existing chip controls for ordinary auth/credential fields and deployment descriptions, retain specialized editing surfaces, and reuse shared chip and dropdown styling definitions.

Intentional visual differences: multiple-selection menus use checkbox rows; segmented groups use zero gap; former large badges use medium sizing; table bulk actions use the adaptive dark fill; migrated fields use chip corners and surfaces while retaining required height constraints. Marketing single-selection checkmarks, form heights, and pricing-toggle treatment are retained.

Validation: all 26 workspace type checks and lint checks, import-specifier checks, API validation, 350 EMCN tests, and 91 relevant consumer tests passed. The migration audit found zero retired-API references or parse failures; all 37 dynamic references were reviewed. Representative product and marketing flows received browser review, including table execution and re-execution. Browser coverage is not exhaustive.

vercel · 2026-09-19T00:53:30Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 23, 2026 2:13am UTC

greptile-apps · 2026-09-19T02:59:17Z

Confidence Score: 5/5

The PR appears safe to merge; no outstanding previous findings or actionable new regressions remain.

Summary

Consolidates overlapping EMCN selection and segmented-control APIs while migrating consumers away from redundant styling variants and legacy controls.

Makes ChipSelect the canonical menu-selection component, including searchable, grouped, and multi-select use cases.
Shares one Radix segmented-control implementation between ChipButtonGroup and ChipSwitch.
Removes unused Button, Checkbox, and Badge variants and migrates affected consumers.
Reuses canonical chip inputs, password fields, geometry tokens, and dropdown styling across product and marketing surfaces.
The changes since the previous review correctly replace the remaining EMCN deep import with the public @sim/emcn barrel.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumers[Product and marketing consumers] --> Select[ChipSelect]
  Select --> Single[Single selection]
  Select --> Multi[Multiple selection]
  Select --> Search[Grouped and searchable options]
  Compound[ChipButtonGroup compound API] --> Segmented[Shared Radix segmented control]
  Adapter[ChipSwitch options adapter] --> Segmented
  Tokens[Shared chip chrome and geometry tokens] --> Select
  Tokens --> Segmented

_{Reviews (6) · Last reviewed commit: "test(emcn): read email geometry from the..."}

cubic-dev-ai

All reported issues were addressed across 87 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-19T03:17:07Z

@greptile

BillLeoutsakosvl346 · 2026-09-19T03:17:08Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-19T03:17:14Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 88 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-19T19:58:39Z

@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit.

cubic-dev-ai · 2026-09-19T19:58:53Z

@greptileai @cubic-dev-ai Please review the current head; the previous scored reviews cover an earlier commit.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 88 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T06:56:33Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T06:56:35Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T06:56:41Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 86 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T19:41:38Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T19:41:39Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T19:41:47Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 88 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T19:46:57Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T19:46:58Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T19:47:04Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 88 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

vercel Bot deployed to Preview September 19, 2026 00:55 View deployment

vercel Bot temporarily deployed to Preview September 19, 2026 01:07 Inactive

vercel Bot deployed to Preview September 19, 2026 01:28 View deployment

BillLeoutsakosvl346 marked this pull request as ready for review September 19, 2026 02:56

greptile-apps Bot reviewed Sep 19, 2026

View reviewed changes

Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

Comment thread apps/sim/ee/organization-usage/components/activity-panel.tsx

Comment thread packages/emcn/src/components/chip-select/chip-select.tsx

Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated

Comment thread packages/emcn/src/components/chip/chip-chrome.ts Outdated

vercel Bot deployed to Preview September 19, 2026 03:18 View deployment

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

vercel Bot deployed to Preview September 19, 2026 16:38 View deployment

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

vercel Bot deployed to Preview September 20, 2026 01:10 View deployment

vercel Bot temporarily deployed to Preview September 21, 2026 03:32 Inactive

vercel Bot deployed to Preview September 22, 2026 06:57 View deployment

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread apps/sim/components/emails/_styles/base.tokens.test.ts Outdated

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

vercel Bot deployed to Preview September 22, 2026 18:00 View deployment

Bill Leoutsakos added 2 commits September 22, 2026 12:20

improvement(emcn): share ordinary action geometry in Button

d583476

improvement(emcn): consolidate selection controls and styling options

a8070bc

BillLeoutsakosvl346 force-pushed the codex/emcn-consolidation branch from bf036a1 to a8070bc Compare September 22, 2026 19:41

BillLeoutsakosvl346 changed the base branch from staging to codex/overrides-button-sizing September 22, 2026 19:41

vercel Bot deployed to Preview September 22, 2026 19:44 View deployment

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

test(emcn): read email geometry from the public export

81e3110

vercel Bot temporarily deployed to Preview September 22, 2026 19:46 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

improvement(emcn): share larger chip and field geometry (#8151)

380bf5d

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

Base automatically changed from codex/overrides-button-sizing to codex/control-fix-icon-button-sizing September 23, 2026 02:12

vercel Bot deployed to Preview September 23, 2026 02:13 View deployment

Conversation

BillLeoutsakosvl346 commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 19, 2026 •

edited

Loading

vercel Bot commented Sep 19, 2026 •

edited

Loading

greptile-apps Bot commented Sep 19, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading