Skip to content

improvement(ui): share knowledge tag rows - #8071

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-destructive-ghost-buttonsfrom
codex/control-fix-knowledge-tag-rows
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-destructive-ghost-buttonsfrom
codex/control-fix-knowledge-tag-rows

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Share tag-row presentation between knowledge-base and document tag modals.
  • Preserve type labels, value truncation, keyboard activation and delete-click propagation.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • External source comparison confirms caller logic and content are unchanged.
  • Before/after browser fixtures cover the changed component's styling and interactions. Original and extracted controls have matching computed styles. These are isolated fixtures, not full authenticated product flows.
  • Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 20, 2026 11:38pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the extraction preserves the existing markup and interaction contracts at both call sites.

Summary

This PR extracts the duplicated knowledge-tag summary row into a shared KnowledgeTagRow component while preserving the two modal-specific behaviors.

  • Reuses a common row layout across knowledge-base and document tag modals.
  • Preserves type labels, value truncation, keyboard activation, and removal event propagation.
  • Keeps the existing destructive button appearance and accessible labels.

Reviews (1) · Last reviewed commit: "improvement(ui): share knowledge tag row..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Knowledge tag rows share their label, type badge, value and delete layout.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: e58eab2e5b.

Before and after: light tag true

Additional theme/state comparisons

Before and after: dark tag true

This branch was previously deployed

1 inactive deployment
Preview e58eab2e Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant