Skip to content

improvement(ui): use chip fields in workflow search and replace - #8076

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/emcn-consolidationfrom
codex/control-fix-search-replace-fields
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/emcn-consolidationfrom
codex/control-fix-search-replace-fields

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use ChipInput for workflow search and text replacement, and ChipCombobox for resource replacement.
  • Keep input refs, keyboard handling, search options and replacement callbacks; adopt standard chip corners, field height and theme-aware surface.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • External source comparison confirms caller logic and content are unchanged.
  • Before/after browser fixtures cover the changed component's styling and interactions. Search-and-replace intentionally adopts chip field styling. These are isolated fixtures, not full authenticated product flows.
  • Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 20, 2026 11:44pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the component substitutions preserve the existing behavior while applying the intended chip-field styling.

Summary

Replaces generic EMCN input and combobox controls in workflow search-and-replace with chip-styled equivalents while preserving existing interaction contracts.

  • Search queries and text replacements now use ChipInput.
  • Resource replacements now use ChipCombobox.
  • Existing refs, keyboard handling, values, callbacks, options, and disabled states remain intact.

Reviews (1) · Last reviewed commit: "improvement(ui): use chip fields in work..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Search fields reuse ChipInput: 34px → 30px high, 4px → 8px corners, shared text color and dark fill. Existing editing logic is retained.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 39573f375f.

Before and after: light search field

Additional theme/state comparisons

Before and after: dark search field

This branch was previously deployed

1 inactive deployment
Preview 39573f37 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant