Skip to content

improvement(ui): use chips for ordinary product actions - #8081

Open
BillLeoutsakosvl346 wants to merge 3 commits into
codex/control-fix-search-replace-fieldsfrom
codex/control-fix-ordinary-chip-actions
Open

improvement(ui): use chips for ordinary product actions#8081
BillLeoutsakosvl346 wants to merge 3 commits into
codex/control-fix-search-replace-fieldsfrom
codex/control-fix-ordinary-chip-actions

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Use existing Chip variants for file/log filter resets, admin pagination, license generation, and preview navigation while preserving handlers and disabled conditions.
  • Keep full-width filter labels centered. The preview workflow-name label shares the adjacent Back chip's geometry and typography.
  • Retain the compact search/replace buttons so the match count stays on one line in the 360px panel.

Type of Change

  • Refactor / maintainability improvement

Testing

  • All workspace type checks and lint pass.
  • All 47 repository audits, including import-specifier and API validation checks, pass; block-registry and docs-manifest checks pass.
  • Complete EMCN suite: 355 tests pass. Existing search/replace consumer suites: 133 tests pass.
  • Browser-rendered source compositions verify the search count stays on one line and filter labels remain centered in light and dark themes. These are local fixtures, not authenticated product flows.
  • No landing changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 5:31pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding or newly introduced actionable issues.

Summary

This PR replaces several ordinary product actions with existing Chip variants while retaining their handlers, disabled states, and intended layout.

  • Converts file and log filter reset controls to full-width Chips with intentionally centered labels.
  • Converts admin pagination and license generation actions to Chips.
  • Aligns preview navigation and workflow-name styling with shared Chip geometry and typography.
  • No code changed since the previous review.

Reviews (4) · Last reviewed commit: "fix(ui): preserve compact replacement ac..."

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/workspace/[workspaceId]/w/components/preview/preview.tsx
@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

greptile-apps[bot]
greptile-apps Bot reviewed Sep 21, 2026
View reviewed changes
Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile Please re-review against the current PR description: full-width clear-filter labels intentionally retain their original centered alignment. The resolved inline thread explains the visual-preservation requirement.

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Logs Clear All Filters reuses Chip while retaining centered text. The final treatment has the standard chip surface, corners and typography.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

This is the corrected final comparison, after restoring centered filter labels. Search replacement buttons are not part of the final change.

Current PR head checked at posting: b2d2c7bd5a.

Before and after: light logs

Additional theme/state comparisons

Before and after: dark logs

This branch was previously deployed

1 inactive deployment
Preview — b2d2c7bd Deployed Sep 21, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BillLeoutsakosvl346