Skip to content

improvement(ui): use shared sizing for small icon actions - #8090

Merged
waleedlatif1 merged 2 commits into
codex/control-fix-field-disclosuresfrom
codex/control-fix-small-header-icons
Sep 21, 2026
Merged

waleedlatif1 merged 2 commits into
codex/control-fix-field-disclosuresfrom
codex/control-fix-small-header-icons

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing 20px Button icon treatment for eight editor, toolbar, chat-header and public-chat actions.
  • Keep glyph sizes, action handlers, labels, tooltips and permission/loading guards; adopt shared corners, icon stroke and neutral icon color. Sampled headers retain their height.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN suite and relevant existing consumer tests pass.
  • Isolated real-component browser fixtures cover light/dark, narrow layouts, enlarged text and disabled states; icon-menu checks cover keyboard selection, Escape and focus restoration. Upload fixtures exercise local action callbacks, not a live upload service.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 2:36am UTC

Request Review

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the changes consistently adopt the existing shared icon-button treatment without altering action behavior.

Summary

This PR standardizes eight small icon actions on the shared Button icon sizing treatment.

  • Replaces local zero-padding overrides with size='icon'.
  • Preserves existing glyph sizes, labels, handlers, tooltips, and disabled/loading behavior.
  • Removes a redundant explicit color from the editor’s unlock glyph so it inherits the shared button styling.

Reviews (2) · Last reviewed commit: "fix(ui): inherit the shared unlock icon ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2d56098 into codex/control-fix-field-disclosures Sep 21, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-small-header-icons branch September 21, 2026 03:31

This branch was previously deployed

1 inactive deployment
Preview 5bde83c9 Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants