Skip to content

improvement(ui): reuse chips for custom block upload actions - #8091

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-resource-comboboxesfrom
codex/control-fix-custom-block-upload-actions
Sep 21, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-resource-comboboxesfrom
codex/control-fix-custom-block-upload-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing outlined Chip for custom-block Upload/Change and the icon Button for Remove.
  • Keep upload callbacks, accepted file types and pending/permission guards. Center the actions beside the unchanged preview; adopt the shared 30px chip geometry and outline.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN suite and relevant existing consumer tests pass.
  • Isolated real-component browser fixtures cover light/dark, narrow layouts, enlarged text and disabled states; icon-menu checks cover keyboard selection, Escape and focus restoration. Upload fixtures exercise local action callbacks, not a live upload service.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 2:30am UTC

Request Review

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the shared components preserve the existing interaction semantics and provide the intended action geometry and styling.

Summary

This PR standardizes the custom-block icon actions on shared EMCN controls.

  • Replaces the Upload/Change Button with an outlined Chip while preserving callbacks and guards.
  • Converts Remove to the established ghost icon Button treatment.
  • Aligns both actions vertically beside the existing preview.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse chips for custom ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 7a86e02 into codex/control-fix-resource-comboboxes Sep 21, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-custom-block-upload-actions branch September 21, 2026 03:31

This branch was previously deployed

1 inactive deployment
Preview 6696b7b6 Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants