improvement(knowledge): warm the search projection after its backfill - #8092
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prewarmSearchProjectionreads both projections' heaps and theirhnsw/tin/ginindexes back into the OS cache withpg_prewarm(…, 'read'), heaps first so the indexes survive when the cache is short. It resolves relations through the search path and skips any relation that fails; warming never fails its caller.pg_prewarmis not a trusted extension, so the application role cannot install it and no migration does. Where it is absent the helper logs a warning and does nothing. A superuser installs it once withCREATE EXTENSION pg_prewarm.bun apps/sim/scripts/prewarm-search-projection.tswarms on demand after any other bulk operation.Type of Change
Testing
readmode, per-relation failure, unreadable catalog) and for the backfill hook (runs once on completion before the connection closes, not when a budgeted run returns its cursor). Each new assertion was checked against a broken implementation.pg_prewarminstalled reads the heap and every HNSW index and reports pages per relation.bun run lint,check:audits,docs-manifest:check, block-registry audit, andtype-checkpass.Checklist