fix(knowledge): keep the GIN ranking for the rest of a search once a page was handed to it - #8110
Merged
Merged
Conversation
…page was handed to it Tin and GIN order candidates differently, so a keyword search whose first page Tin could not fill, and which GIN supplied, must not resume Tin at GIN's offset on a later page. The leg now stays with GIN for the rest of that search.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.concurrently()flag suggested alongside it is deliberately not added: drizzle would generate a drop-and-rebuild of the live index for a flag that only changes generated SQL, and the migration that created the index already builds it concurrentlyType of Change
Testing
vitestoverlib/knowledgeandapp/api/knowledge(191 files, 3304 tests),bun run lint,bun run check:auditsand nativetsc --noEmitpassChecklist