Skip to content

v0.8.50: search - #8114

Merged
waleedlatif1 merged 4 commits into
mainfrom
staging
Sep 21, 2026
Merged

waleedlatif1 merged 4 commits into
mainfrom
staging

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 21, 2026 7:35pm UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit 7ae224c into main Sep 21, 2026
28 checks passed
@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR should not merge until the shard ranges cover boundary-valued text IDs; the Slack scope expansion should also be narrowed to reduce credential authority.

Findings

  1. P1 Shard Boundaries Skip IDs
  2. P2 Security Custom Apps Gain Excess Privileges

Summary

This PR adjusts access-scoped search reach counting, parallelizes the projection source/ACL backfill, and aligns custom and shared Slack manifests.

  • Caps reach counting to the probe budget and treats a proven empty reach as a bounded empty set.
  • Splits projection repair into tagged Trigger.dev shard chains and delays analysis/prewarming until all fillable rows are complete.
  • Adds channel-picker bot scopes and gives custom Slack manifests the shared app’s broader permission sets.
  • One shard-boundary gap can leave valid text IDs permanently unfilled, and the custom manifest expansion grants avoidable high-impact permissions.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Operator starts projection backfill] --> B[Create one tagged chain per shard]
  B --> C[Fill semantic projection range]
  C --> D[Fill keyword projection range]
  D --> E{Any fillable rows remain?}
  E -->|Yes| F[End this shard without prewarming]
  E -->|No| G[Analyze projections]
  G --> H[Prewarm ranking pages]
  I[Search request] --> J[Probe permitted documents]
  J --> K[Count reach within probe budget]
  K -->|Count is zero| L[Bounded empty result]
  K -->|Count times out| M[Continue with unbounded search]
  K -->|Non-empty| N[Choose broad or narrow strategy]
Loading

Reviews (1) · Last reviewed commit: "feat(knowledge): fill the projection sou..."

Comment thread packages/db/script-migrations/0021_embedding_search_connector.ts
Comment thread apps/sim/lib/slack-search/manifest.ts

This branch was successfully deployed

1 active deployment
Preview e07e7bab Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants