Skip to content

chore(trigger): upgrade Trigger.dev to 4.5.16 so deploy images build without deleting node_modules - #8118

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/trigger-4-6-3
Sep 21, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/trigger-4-6-3

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • bump the Trigger.dev CLI pin in CI and @trigger.dev/sdk, @trigger.dev/core, @trigger.dev/build from 4.5.12 to 4.5.16, kept in lockstep
  • 4.5.11 introduced a deploy regression: the generated Containerfile built the code layer by snapshotting the build stage and running chmod -R … && rm -rf node_modules over the whole dependency tree. With this worker's dependency tree that step alone takes 7 to 26 minutes, which is what pushed today's release deploys past both the CI job limit and Trigger.dev's own deployment timeout
  • 4.5.16 (fix(cli): build the code layer with an exclude copy instead of deleting node_modules triggerdotdev/trigger.dev#4878) builds the code layer with COPY --exclude instead, so the step disappears
  • 4.5.16 is the smallest version that carries the fix and stays in the same minor line; 4.6.x is currently held back by the repo's 7-day minimum release age

Type of Change

  • Dependency upgrade

Testing

  • bun run type-check in apps/sim passes
  • Trigger-facing unit tests pass (backfill task, cleanup dispatcher, async-jobs)
  • the worker uses only task, tasks, queue, timeout, idempotencyKeys, runs, AbortTaskRunError; none of the 4.5.13–4.5.16 changes touch those
  • the staging deploy on merge is the real verification: the Prepare Trigger.dev job should drop back to a few minutes and the build log should show no rm -rf node_modules step

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner September 21, 2026 20:53
@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 21, 2026 8:54pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with all Trigger.dev CLI and package versions aligned and no concrete compatibility regression identified.

Summary

This PR upgrades Trigger.dev from 4.5.12 to 4.5.16 to avoid the slow dependency-tree deletion performed while building deployment images.

  • Keeps the deploy and promotion CLI versions aligned.
  • Upgrades SDK, core, and build packages together.
  • Regenerates the Bun lockfile with internally consistent 4.5.16 resolutions.

Reviews (1) · Last reviewed commit: "chore(trigger): upgrade Trigger.dev to 4..."

@waleedlatif1
waleedlatif1 merged commit 2645f1c into staging Sep 21, 2026
37 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/trigger-4-6-3 branch September 21, 2026 20:58

This branch was successfully deployed

1 active deployment
Preview b2cb6c1a Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant