Skip to content

v0.8.53: indexing fixes - #8124

Merged
waleedlatif1 merged 3 commits into
mainfrom
staging
Sep 22, 2026
Merged

waleedlatif1 merged 3 commits into
mainfrom
staging

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

BillLeoutsakosvl346 and others added 3 commits September 21, 2026 15:03
Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
…canning the whole document table (#8122)

* fix(knowledge): index the connector tombstone check so a sync stops scanning the whole document table

* chore(db): format the generated migration metadata
…dex row cannot fail a connector sync (#8123)

* fix(knowledge): bound source titles and tag values so an oversized index row cannot fail a connector sync

* test(knowledge): pin the exact indexed-text boundary

* fix(knowledge): share the indexed-text bound, cut by code point, and reject oversized filenames and tags at the document APIs

* fix(knowledge): cut bounded text with a shared surrogate-safe helper inside the limit and leave stored upload metadata untouched

* fix(knowledge): leave values at the limit untouched and refuse over-long tag values on the tag-data and tag-update paths
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 3:50am UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit e12a264 into main Sep 22, 2026
65 checks passed
@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The behavioral changes appear sound, but the repository’s component-local styling requirement must be satisfied before merging.

Findings

  1. P2 Global Styling Violates Requirements

Summary

This PR improves knowledge connector indexing reliability and centralizes several UI colors.

  • Adds a partial connector tombstone index using the repository’s concurrent-index migration pattern.
  • Bounds indexed document filenames and tag values, truncating machine-provided connector values without splitting surrogate pairs.
  • Moves collaborator and product colors to CSS variables and updates selection/caret rendering for both CSS-variable and legacy hex colors.
  • The global theme edit conflicts with the repository’s explicit styling requirements.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  API[Document API input] --> Validate[Reject filenames and tags over 512 units]
  Connector[Connector source data] --> Truncate[Truncate titles and mapped tags to 512 units]
  Validate --> Write[Document persistence]
  Truncate --> Write
  Write --> Indexes[Filename and tag btree indexes]
  Sync[Connector tombstone query] --> Tombstone[Partial connector tombstone index]
Loading

Reviews (1) · Last reviewed commit: "fix(knowledge): bound source titles and ..."

Comment on lines +236 to +246
/** Runtime collaborator colours must exist even without a matching utility class. */
@theme static {
--color-black: #000000;
--color-white: #ffffff;
--color-amber-300: #fcd34d;
--color-orange-400: #fb923c;
--color-pink-400: #f472b6;
--color-purple-400: #c084fc;
--color-violet-500: #8b5cf6;
--color-cool-gray-500: #6b7280;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Global Styling Violates Requirements

This adds eight color variables in a new global @theme block. The repository requires styling changes to remain local to components and specifically says to avoid editing globals.css unless absolutely necessary. This requirement must be satisfied before merging by keeping these colors in the relevant component styles or retaining local color values.

Rule Used: Avoid editing the globals.css file unless absolutely necessary. Move style changes to local component files instead. (source)

Learned From
simstudioai/sim#367

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch was successfully deployed

1 active deployment
Preview fe7d6d37 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants