Skip to content

improvement(ui): consolidate product typography - #8132

Open
BillLeoutsakosvl346 wants to merge 5 commits into
codex/control-fix-public-auth-headingsfrom
codex/typography-consolidation
Open

BillLeoutsakosvl346 wants to merge 5 commits into
codex/control-fix-public-auth-headingsfrom
codex/typography-consolidation

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Consolidate product text onto the shared typography scale, explicitly adopt the existing 14/20/24px rem sizes, and add the repeated 28/32/40px heading roles.
  • Normalize workflow titles 17→16px, panel tabs 12.5→13px, tiny labels 9→10px, narrow headings 26→24px, and the upgrade heading 30→28px. Normalize four light weights to 400 and the block fallback to 600. Platform demonstrations follow the workflow title change.
  • Preserve explicit/inherited line heights, scoped Inter loading, document-relative sizing, monospace fields, and component geometry. Remove seven redundant text overrides and teach cn the new size names.

Type of Change

  • Improvement

Testing

  • All workspace type and lint checks; 47 audits, import specifiers, strict API validation, and generated-artifact checks pass.
  • Full application suite: 55,118 passing tests; EMCN: 362; workflow renderer: 144. Remaining workspace suites pass. Platform demonstration tests: 16.
  • Browser comparisons cover home headings/composer alignment, workflow titles and tabs, note editing, rich documents, public headings, and marketing demonstrations. Document computed typography matches the baseline. Isolated source-treatment previews supplement unavailable billing/SSO/presence states and are labeled separately.
  • External finding ledger accounts for all 152 refreshed typography findings. Linters, reports, and screenshots are kept outside the product diff; representative image comparisons are attached below.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:43am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The changes since the previous review appear safe to merge, with no new actionable correctness or security issue identified.

Summary

Consolidates product typography around shared named size and weight tokens.

  • Adds reusable typography roles for standard text, titles, and display headings.
  • Replaces arbitrary sizes and off-scale weights across application and workflow-renderer components.
  • Extends cn conflict resolution and tests for the new named font-size utilities.
  • Preserves specialized line heights, monospace fields, and scoped Inter usage.

Reviews (4) · Last reviewed commit: "improvement(ui): align public email veri..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 58 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/_styles/globals.css
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff

These findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.

  • P2 Global styling rule violation apps/sim/app/_styles/globals.css:74

    This change adds shared font, weight, size, and line-height definitions to globals.css. That violates the repository directive to never update global styles and to keep styling local to components. This requirement must be satisfied before merging.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 58 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

The global-scale changes are an explicit, approved part of this typography consolidation. The requested implementation centralizes shared sizes, weights, and the existing scoped Inter utility in globals.css; applying the general no-global-style-edits rule here would reverse that approved scope.

The imported 14/20/24px rem values and their default leading are preserved. The new 28/32/40px tokens represent existing repeated heading roles, and the other visual size/weight consolidations are described in the PR. Inter is still loaded only within its existing boundary. These are deliberate central definitions, not accidental global overrides, so no code change is appropriate for the outside-diff finding.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Representative before/after comparisons from the real application, using the same viewport, canvas scale, theme, and control state.

  • Workflow titles: 17px → 16px.
  • Panel tab labels: 12.5px → 13px; button height remains 28px.
  • Editable note title: 17px → 16px; the input rectangle remains unchanged, and Escape restores the previous title.

The close-ups below are enlarged from retained original screenshots.

Before and after: workflow titles, panel labels, and note editing

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 59 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview 69a0277d Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant