improvement(ui): share inline filter and pagination actions - #8163
waleedlatif1 merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
Before → after visual checks for 527752b. Actual filter heading and extracted pagination logic, with local state. No product data requests. Clear, page selection, keyboard activation and disabled boundaries were exercised. Intentional differences: page labels 14→12px; shared 20px height and horizontal padding widen targets. Selected-page text keeps its previous color and uses the shared subtle hover fill. Light — before left, after right: |
c9b29fb
into
codex/control-fix-knowledge-filter-headings



Clear and page-number buttons now use Button
size="inline"and existing neutral variants. The current page retains its body text color and is marked witharia-current. Pagination calculation, disabled boundaries and callbacks are unchanged.Intentional differences: page labels 14→12px, shared 20px height and 6px horizontal padding; Clear uses the shared hover text, and selected-page hover uses the subtle fill.
All workspace type checks, import/API audits, lint and the complete EMCN suite pass. Relevant resource consumer tests pass. Browser fixtures exercise Clear, pagination boundaries, keyboard selection, light/dark themes and enlarged text. Product data requests were not exercised. No review artifacts or linters are included.
Both external linters ran against the actual target: all 12 targeted overrides removed (851 → 839 findings), no added full-scan findings and zero diff-checker violations.