Skip to content

improvement(ui): share inline filter and pagination actions - #8163

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-knowledge-filter-headingsfrom
codex/overrides-text-actions
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-knowledge-filter-headingsfrom
codex/overrides-text-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Clear and page-number buttons now use Button size="inline" and existing neutral variants. The current page retains its body text color and is marked with aria-current. Pagination calculation, disabled boundaries and callbacks are unchanged.

Intentional differences: page labels 14→12px, shared 20px height and 6px horizontal padding; Clear uses the shared hover text, and selected-page hover uses the subtle fill.

All workspace type checks, import/API audits, lint and the complete EMCN suite pass. Relevant resource consumer tests pass. Browser fixtures exercise Clear, pagination boundaries, keyboard selection, light/dark themes and enlarged text. Product data requests were not exercised. No review artifacts or linters are included.

Both external linters ran against the actual target: all 12 targeted overrides removed (851 → 839 findings), no added full-scan findings and zero diff-checker violations.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 9:43pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the changes are limited to intentional shared-button styling and an accessibility annotation.

Summary

This PR consolidates pagination and knowledge-filter actions onto shared Button styling while preserving their existing callbacks.

  • Pagination page buttons now use the inline size, neutral variants, and aria-current="page" for the selected page.
  • Knowledge filter Clear actions now use the shared inline geometry and ghost-secondary treatment.
  • No concrete correctness, accessibility, security, or repository-rule violations were identified.

Reviews (1) · Last reviewed commit: "improvement(ui): share inline filter and..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after visual checks for 527752b. Actual filter heading and extracted pagination logic, with local state. No product data requests. Clear, page selection, keyboard activation and disabled boundaries were exercised.

Intentional differences: page labels 14→12px; shared 20px height and horizontal padding widen targets. Selected-page text keeps its previous color and uses the shared subtle hover fill.

Light — before left, after right:
clipboard

Dark — before left, after right:
clipboard

Controls — 2× enlarged crop:
clipboard

@waleedlatif1
waleedlatif1 merged commit c9b29fb into codex/control-fix-knowledge-filter-headings Sep 23, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-text-actions branch September 23, 2026 02:12

This branch was previously deployed

1 inactive deployment
Preview 527752b3 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants